From: hongbo li <herbert.tencent@gmail.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: "open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>,
linux-crypto@vger.kernel.org,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Eric Biggers" <ebiggers@kernel.org>,
"David Howells" <dhowells@redhat.com>,
jarkko@kernel.org, "herberthbli(李弘博)" <herberthbli@tencent.com>,
"open list" <linux-kernel@vger.kernel.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/7] crypto: fix a memory leak in sm2
Date: Mon, 31 May 2021 20:43:04 +0800 [thread overview]
Message-ID: <CABpmuwLUZY=aPjeH=AdPvP2jq2+jnTyUyLLOoAwCg+hBZJB2Xg@mail.gmail.com> (raw)
In-Reply-To: <47cf4353-b4bb-3907-6017-60bf87805d0c@linux.alibaba.com>
Tianjia Zhang <tianjia.zhang@linux.alibaba.com> 于2021年5月28日周五 下午2:27写道：
>
> Hi Herbert, Hongbo,
>
> On 5/27/21 9:53 PM, Hongbo Li wrote:
> > From: Hongbo Li <herberthbli@tencent.com>
> >
> > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> > test_akcipher_one(), it will set public key for every test vector,
> > and don't free ec->Q. This will cause a memory leak.
> >
> > This patch alloc ec->Q in sm2_ec_ctx_init().
> >
> > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> > Signed-off-by: Hongbo Li <herberthbli@tencent.com>
> > Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> > ---
> > crypto/sm2.c | 24 ++++++++++--------------
> > 1 file changed, 10 insertions(+), 14 deletions(-)
> >
>
> Patch 1/7 is an independent bugfix patch. If possible, consider applying
> it first.
>
> The commit message header should start with: crypto: sm2 -
>
> Also added:
>
> Cc: stable@vger.kernel.org # v5.10+
>
> Best regards,
> Tianjia
OK, will send this patch later.
Regards,
Hongbo
next prev parent reply other threads:[~2021-05-31 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 13:53 [PATCH v2 0/7] crypto: add eddsa support for x509 Hongbo Li
2021-05-27 13:53 ` [PATCH v2 1/7] crypto: fix a memory leak in sm2 Hongbo Li
2021-05-28 6:27 ` Tianjia Zhang
2021-05-31 12:43 ` hongbo li [this message]
2021-05-27 13:53 ` [PATCH v2 2/7] lib/mpi: use kcalloc in mpi_resize Hongbo Li
2021-05-27 13:53 ` [PATCH v2 3/7] lib/mpi: export some common function Hongbo Li
2021-05-27 13:53 ` [PATCH v2 4/7] x509: add support for eddsa Hongbo Li
2021-05-27 13:53 ` [PATCH v2 5/7] crypto: move common code in sm2 to ec_mpi.c and ec_mpi.h Hongbo Li
2021-05-27 13:53 ` [PATCH v2 6/7] crypto: ed25519 cert verification Hongbo Li
2021-05-27 13:53 ` [PATCH v2 7/7] crypto: add eddsa test vector Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABpmuwLUZY=aPjeH=AdPvP2jq2+jnTyUyLLOoAwCg+hBZJB2Xg@mail.gmail.com' \
--to=herbert.tencent@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=herberthbli@tencent.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).