From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2C7C43381 for ; Tue, 2 Apr 2019 03:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 096CA207E0 for ; Tue, 2 Apr 2019 03:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FK03rLKm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728761AbfDBDcn (ORCPT ); Mon, 1 Apr 2019 23:32:43 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:42760 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbfDBDci (ORCPT ); Mon, 1 Apr 2019 23:32:38 -0400 Received: by mail-io1-f66.google.com with SMTP id c4so9680906ioh.9 for ; Mon, 01 Apr 2019 20:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HKtA2OgqesJBgzJYv1b+Ap0iRtQayk+lqCYbZ43xI8w=; b=FK03rLKmh+06R2ISmVFdO7t/8HBcyHS2UDZoQoNlv9KGwRE+69v+4KB4ebmrk2/J71 0DeUU2S8KwGTfOSfxly4wSnuwxE6ewXSxBLMstzrDwfu/4Qx+1hPDmjBBIFj4yhIvEIA Bpzv5Rci63I0JFxRytOShr4IFrPuCGvBtpoTWNY6fs4ENlG/LB3Wqsdm3jFeKSuKXY+s 99k9Y7eyKX8e/aGaI5E7jx2G9iOq+NYuWLfwX/mopoJiTmbm23d+Zsim3b/YwNb0nsuh WEZUY7IFvGoag9ePUe2PMs9DXUvVU6iyp5yk06iroetquCDju7bjtWGovkql1pXOyLvE sdKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HKtA2OgqesJBgzJYv1b+Ap0iRtQayk+lqCYbZ43xI8w=; b=Y2168X6JO7cAZa01rIDShFX02h8vuFGy+csTcqYykogwOQ8XdSfCwqGRqXTtd4Dywk D3BDQgtw94feQ/XqapaSCaR7y++54mIBWw4oI/0P1x/P4VtORCgBF8JEeDSJQCi81KJ6 I1lwl7T4KaBejuTc1zE0mTrG1XS6YZqsE9Hza6UFptHm3Tq2/alRGPFWdknSO+NwFRpX J4evXMDzsj2574QLM7IMAxTUICqLNp/T6DPdc3Ssp5njYZwlEty48/9dZ74i/VCjrM9k un/uerK5lhBEKtpPhHYoKKTIaJQvCc9Htx7mzANaLpEz5hNZohtLEZGULuFvAkhtouXj pSAw== X-Gm-Message-State: APjAAAVmRNzNRbzYhI+jYqv1RbZt0VSWhUURLMLSloc48uX2svz5RtI6 aq2n+ktxT4CwKgfOS5hCn/Ur65GY/RkQrOmyNGvf5Q== X-Google-Smtp-Source: APXvYqyZsfl/tvgNCDWz0p3ouDKb+EqMbRCuHOu/5wT+soY7NpSaj22jNyr0K+QB2W87ITBd0Ec0w4XjUQ+pDdk4A7E= X-Received: by 2002:a6b:3106:: with SMTP id j6mr2342777ioa.147.1554175957400; Mon, 01 Apr 2019 20:32:37 -0700 (PDT) MIME-Version: 1.0 References: <20190227202658.197113-1-matthewgarrett@google.com> <20190401235245.GA29282@linux.intel.com> In-Reply-To: <20190401235245.GA29282@linux.intel.com> From: Matthew Garrett Date: Mon, 1 Apr 2019 20:32:26 -0700 Message-ID: Subject: Re: Add support for TCG2 log format on UEFI systems To: Jarkko Sakkinen Cc: tomas.winkler@intel.com, linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Apr 1, 2019 at 4:52 PM Jarkko Sakkinen wrote: > > On Wed, Feb 27, 2019 at 12:26:54PM -0800, Matthew Garrett wrote: > > Identical to V4, but based on tpmdd-next > > OK, so on my GLK NUC I get valid final log and invalid event log > after adding some extra klogs. > > I.e. > > - if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) > + if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { Just to make sure - are you booting via the EFI boot stub? We need to obtain the boot log before ExitBootServices() is called, so if you're booting directly into the 32-bit entry point (eg, by using the "linux" command in grub) then you won't get a log.