From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F7B0C43219 for ; Thu, 2 May 2019 18:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 537982089E for ; Thu, 2 May 2019 18:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AHmFY0vp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfEBSDV (ORCPT ); Thu, 2 May 2019 14:03:21 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:38510 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfEBSDU (ORCPT ); Thu, 2 May 2019 14:03:20 -0400 Received: by mail-it1-f196.google.com with SMTP id q19so4963175itk.3 for ; Thu, 02 May 2019 11:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pxRYtB+CK6Ich2oLVLgzBqTdwyqbVB4RtVqM1iRZzuk=; b=AHmFY0vpHLiYI3WSJEyOMUm1XfkTvSqPKSXw7HXgBlZL663topOcjXDnBPRqIqlJBZ 41mzOPiqZaRtuyFfHaL4mGPxlCLNHu4LV2R7fWyVBFrX/iHu/sT8OcmEoNEmFBIohMaB 1zzdwFk0aOGsG8ei3M4dHdTt7jBYuJCq/uKAybSgLx0QIWRh4yXJ48BbMciuTz9jrWto NVeD6ozfjOaWvO3Eso+0U/ljm39krOkrfHpLrfyb4uCaEq8BXNyShmacpEduMePeZnTu IbXH83VvWrEFWFA12FOu80yYxNDIqLTFG4pgYFy8HKi5s7DZwfr28Z5lro8hdbiLOdVN nqMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pxRYtB+CK6Ich2oLVLgzBqTdwyqbVB4RtVqM1iRZzuk=; b=b16+psAQ71WX0VtaUgDKOfVjXc3+j8n/8db8NQrY3lsCVTTteO6N/EJmUO6L4iDjku EOqqdqGCkVQLyZb4XYiJRnnz49a07LZt0JabOxo9FHMdQXJP9/fEEmy7VFBc6t33gQ3u ly3Es/QBKmisXtRt5p6TeAPI/TWyvRK1W3dA4iw+/Rbpswb8Cdy0HeB32JyG+DQq3F9n nsj751ACynI2jDqh2sIFFm6iU08v3TlGxiKpBz+bqY3LTQCPgf1sF3NP9NDKTQddMqbv +OdkzqpxEr35S6SrdgkcgU5jC8IYTxSnX+2OJ7/J+hrT0Klb2SU5/ecFzdLWeeSLX7d2 FMCA== X-Gm-Message-State: APjAAAVOkWuyFdp8S97JtYX3XUoRpfcxSA0/Sbt8WMsDAag3uuJI6NtJ VoXS8YtgpeCuuUZM9PRjPvdsCD9GrPg8v9yxDmtTBw== X-Google-Smtp-Source: APXvYqyqfla42J1qTMxEwr32GVdabbeeY3qkXtELGveMOE53U2Kq5Sc4qHI4ai6a8x3wPxU1FzWZVuf2XCzdmkD/TOA= X-Received: by 2002:a24:eb04:: with SMTP id h4mr3780308itj.16.1556820199498; Thu, 02 May 2019 11:03:19 -0700 (PDT) MIME-Version: 1.0 References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> <20190502083240.GJ14532@linux.intel.com> In-Reply-To: <20190502083240.GJ14532@linux.intel.com> From: Matthew Garrett Date: Thu, 2 May 2019 11:03:08 -0700 Message-ID: Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table To: Jarkko Sakkinen Cc: Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, May 2, 2019 at 1:32 AM Jarkko Sakkinen wrote: > > On Tue, Apr 30, 2019 at 03:07:09PM +0200, Bartosz Szczepanek wrote: > > I may be a little late with this comment, but I've just tested these > > patches on aarch64 platform (from the top of jjs/master) and got > > kernel panic ("Unable to handle kernel read", full log at the end of > > mail). I think there's problem with below call to > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > passed as (void *) and never remapped: > > Not late. This is not part of any PR yet. Thank you for the > feedback! > > Matthew, can you send an updated version of the whole patch set > with fixes to this issue and also reordering of the includes? Yes, I'll resend and let's do this again for 5.3.