From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5759BC2D0F7 for ; Tue, 12 May 2020 20:08:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CFD120769 for ; Tue, 12 May 2020 20:08:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ecXKDWAv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730210AbgELUIZ (ORCPT ); Tue, 12 May 2020 16:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbgELUIZ (ORCPT ); Tue, 12 May 2020 16:08:25 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A2FAC061A0C for ; Tue, 12 May 2020 13:08:24 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id e18so2678642iog.9 for ; Tue, 12 May 2020 13:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iQ1FXZEo9sAqjvXhulqp1o6Tr1qWg73VyBJS6q3oQSY=; b=ecXKDWAvXHXgK5DVRc/9P3enNHhO8C04BA3CHfw832WJhzTW/8Jvz8pSm5v6kGOwRh UxViVF4GBzwkr3OEqVP1+jwEU0HezbZzzXDr5SU64CyDZuDt7C/3eddKQl467oT7SmI/ jmM6cwOkfByiCZwY86b7IJ3OrwgFjG/zvmAxkv3z5964GQ4iyAgZc50qxl2cFxgwgnaL 6UbuX+0K56gD7rVwSxQLP6D5yFSYCH9v9XcZpXYGwAy1nFSRtxsLxEKpS5XZ+K/zmee6 GJw8Ddd9NHnc8ZoedlfOTIFEOx1bjj68zSOg3ANjoVdI2BfchZ368LlLAnSe2DL4M1RU tXdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iQ1FXZEo9sAqjvXhulqp1o6Tr1qWg73VyBJS6q3oQSY=; b=gISTWS5EEtuKylZvNE6t/AXo2t39kaiAD0Wz96aqwJvp4o3zMB33dQZuTWjwbPVeiY sQeYr8Q8lQgE698oVd3Km9erMvcZ0xpwBbeOUWYv8dFshR6H845iDPFf14pVhmNGffz5 SpKMYyV8biDhXzmRaOnSJXb+d6QXYKpnpP/FvcBUpCBHdxswtWkR/lryVExa52IzIDFr JmHJha/G1eQYxxO168aVbw5FVPCkgvzIe9cfkIYBFAd6XHFmQ8pEqlhAFbF9VLX64Edq eoirZyT10ZqfDmY1FfNiTAvn8UVhA9p/GqHedSplH6ZTYQR6ZLtCDI6w+celWYh+7d5z MIAA== X-Gm-Message-State: AGi0Puarjfmzxz/Iq2EBUskDZe1ZQQBeIgxmy3jdDMPoU223wPFajrgc 22Kxc7qijNHVqCldP30388FEVmR0SFGhiWtm/PVjQpIt X-Google-Smtp-Source: APiQypL4wFQfR0vZuCymK1dKdrMRavz8+o57sMdnaXLgL7YcBWqhLJJKPwFM8PpGH9W+rYkFS8f7AILNfFqJMoWAuDk= X-Received: by 2002:a02:1746:: with SMTP id 67mr3911965jah.103.1589314103323; Tue, 12 May 2020 13:08:23 -0700 (PDT) MIME-Version: 1.0 References: <20200512040113.277768-1-loic.yhuel@gmail.com> In-Reply-To: <20200512040113.277768-1-loic.yhuel@gmail.com> From: Matthew Garrett Date: Tue, 12 May 2020 13:08:12 -0700 Message-ID: Subject: Re: [PATCH] tpm: check event log version before reading final events To: =?UTF-8?Q?Lo=C3=AFc_Yhuel?= Cc: linux-integrity , Ard Biesheuvel , Jarkko Sakkinen , Javier Martinez Canillas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, May 11, 2020 at 9:01 PM Lo=C3=AFc Yhuel wrot= e: > We get an event log in the SHA-1 format, which doesn't have a > tcg_efi_specid_event_head in the first event, and there is a final events > table which doesn't match the crypto agile format. This seems like a firmware bug, but we definitely shouldn't fail as a resul= t. Reviewed-by: Matthew Garrett