From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E852C43219 for ; Thu, 2 May 2019 18:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 640E32089E for ; Thu, 2 May 2019 18:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f6K3kASC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbfEBSEQ (ORCPT ); Thu, 2 May 2019 14:04:16 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:33520 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbfEBSEP (ORCPT ); Thu, 2 May 2019 14:04:15 -0400 Received: by mail-io1-f65.google.com with SMTP id u12so3028661iop.0 for ; Thu, 02 May 2019 11:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SU8aAABM065YNEdWIrP9VLfp6wM73Cy7sMn9LwYteHs=; b=f6K3kASCYwWOdpWL00hYEo/+O/+CwPAE2qa1EtzQcxap9LAXrl7bqlrPM0S9hqlXsQ qX1HzZF4jMJasflI6Mybe9MKHpeTHoWe5acw8gOxw8Hf9pIhift/FFiimHgdv2e4xZfb 9kf/xiRQxrC/X8/LFpH6zxYwZ4Wn+mxVYzkhqbPxAfzwgjb60gpIKkR4SlezVynmltla wTVQkENc8evGTLe+QtK8AJopchFw5aKJ7SA+Gf4T3TrKQPeZB9KFLZ+YusbTSKcVvgf+ 8lb7chFVhHZ5bqsR3MBHXCsCgth8bLv9Qb4BtrcxHEASc7H/izDiylpK/cJV/CYmLy8D gDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SU8aAABM065YNEdWIrP9VLfp6wM73Cy7sMn9LwYteHs=; b=qG5fBdmda5n/JhhqKmlNPbwQ90WluU5pNW4aq0d+/SbK0Z6i6B03GUUv8zfHAUsCdn 9ONVNwBg1BP1rGal3QIsyeyhepOf2rBs3zs72JN38shTM7Rlb2kx9LA4xgLc7vsgDNz+ Lmv0pAP37tWYSiq/sMvsBLH42P72zmy0Hu01j8kWbX+btKS7K77252YNZMGS4HD+DRyf rCjqJ20mCDdl5MjDmfeOvx4+oTlUw7YtYrLKrlsaiOVOcgjDBZnO+VW8RR07hRUmfRyX ZE0gHZtxesffjpM6SsIwMAvJUVB49/+HIUT5YYKpg9VOdgivj64xlbnRj5+dekSbTWwd LQEA== X-Gm-Message-State: APjAAAXAsS79uTasr10ff79KxFn76zwXAIl7XMOxyiZHF8y1pITw3fo2 LKE5tzHhhLV9nzxBBDiRgACb/Pbd/J5syP57qqzUbg== X-Google-Smtp-Source: APXvYqyOj3bra2PT4XDD15cGgua2vqDCD5l2gbA7o5aTdMvJLqabYtOM7r7Cn1WgphZlqar6cqRNgFtIRQ6JGsZ4xt0= X-Received: by 2002:a5e:8348:: with SMTP id y8mr3682573iom.88.1556820254756; Thu, 02 May 2019 11:04:14 -0700 (PDT) MIME-Version: 1.0 References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> In-Reply-To: From: Matthew Garrett Date: Thu, 2 May 2019 11:04:03 -0700 Message-ID: Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table To: Ard Biesheuvel Cc: Jarkko Sakkinen , Ingo Molnar , Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, May 2, 2019 at 12:15 AM Ard Biesheuvel wrote: > > (+ Ingo) > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > > > I may be a little late with this comment, but I've just tested these > > > patches on aarch64 platform (from the top of jjs/master) and got > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > mail). I think there's problem with below call to > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > passed as (void *) and never remapped: > > > > Yes, it looks like this is just broken. Can you try with the attached patch? > > I'm a bit uncomfortable with EFI code that is obviously broken and > untested being queued for the next merge window in another tree. The patchset was Cc:ed to linux-efi@. Is there anything else I should have done to ensure you picked it up rather than Jarkko?