From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBFDC3A5A8 for ; Tue, 3 Sep 2019 16:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49F182339D for ; Tue, 3 Sep 2019 16:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jkuHlxpe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730598AbfICQkH (ORCPT ); Tue, 3 Sep 2019 12:40:07 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:42263 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730635AbfICQju (ORCPT ); Tue, 3 Sep 2019 12:39:50 -0400 Received: by mail-io1-f67.google.com with SMTP id n197so35443205iod.9 for ; Tue, 03 Sep 2019 09:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N4ZEq7vH4LyybBLltNPsggnz+MnaF8ltq7+1mV3M7z8=; b=jkuHlxpeTffQzyKV7i+2JpBXYeno5qGkifyuRpdFr9yRwi+/bp2jvkxx9lYBVPAkpc QoZrOZWkcUWulrSc1aWcPUCpSqIXq3wwat3oMQyk/b84xNgzpclPZvcP0kSIs7YfB7i6 CBNOVJronTNdu4mWyF/x5DwEr0QXKAykO90Ug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N4ZEq7vH4LyybBLltNPsggnz+MnaF8ltq7+1mV3M7z8=; b=NjzeOGtfvOO9i+PpX+cTkPKaBnEDykAt7lafwBDSZW5gen+TnVriofxR6GEIgeCab+ Ms5pL/ycfoJrR8y0BsYJRtaBVEjRWB6hm8uM3TwjlnsPQ3hQu/Lvjrl3fwGU4G/A64J3 /8G+l24pN5hfq3fvTghYufi8MXrDshdNDjw5zzw0Piu3ZwwuGhTsE7SLDy4qEnC+ZL5H FJtpaGyILjjQ036hp+h1rmW8XGGD+QuVZb+gWX1/+kVzf5Uo2yruoK5v/mSjr50jDk0t Edsujq8+SEsw7J+1MU6k/5s/zkKxYTdTEY0CjJk/T1rP2/AewwcwWiFeJ8PWjx4xDwMI LWxA== X-Gm-Message-State: APjAAAWtJe18102trqtocZNie6kUuVAjCYsA4plgefa+oILONeihWs4p 5fyqtfCykXgpkUp0jpZ2Anpn+nf1xCE= X-Google-Smtp-Source: APXvYqx7JxbJPlRoanItNZKZKGCdslyrokfRAROoUKdnsTJ2ne5bO536zAzBODnc3KWeisZPllZDIg== X-Received: by 2002:a5d:974d:: with SMTP id c13mr15004771ioo.87.1567528788843; Tue, 03 Sep 2019 09:39:48 -0700 (PDT) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id l13sm18785586iob.73.2019.09.03.09.39.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2019 09:39:48 -0700 (PDT) Received: by mail-io1-f43.google.com with SMTP id j4so37343753iog.11 for ; Tue, 03 Sep 2019 09:39:48 -0700 (PDT) X-Received: by 2002:a02:a703:: with SMTP id k3mr26897198jam.12.1567528787667; Tue, 03 Sep 2019 09:39:47 -0700 (PDT) MIME-Version: 1.0 References: <20190903162519.7136-1-sashal@kernel.org> <20190903162519.7136-126-sashal@kernel.org> In-Reply-To: <20190903162519.7136-126-sashal@kernel.org> From: Doug Anderson Date: Tue, 3 Sep 2019 09:39:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations To: Sasha Levin , Jarkko Sakkinen Cc: LKML , "# 4.0+" , Vadim Sukhomlinov , linux-integrity@vger.kernel.org, Jason Gunthorpe Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi, On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin wrote: > > From: Vadim Sukhomlinov > > [ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ] > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future TPM > operations weren't disabled, causing rare issues. This patch ensures > that future TPM operations are disabled. > > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") > Cc: stable@vger.kernel.org > Signed-off-by: Vadim Sukhomlinov > [dianders: resolved merge conflicts with mainline] > Signed-off-by: Douglas Anderson > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Jarkko Sakkinen > Signed-off-by: Sasha Levin > --- > drivers/char/tpm/tpm-chip.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Jarkko: did you deal with the issues that came up in response to my post? Are you happy with this going into 4.19 stable at this point? I notice this has your Signed-off-by so maybe? -Doug