From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96294C433EF for ; Tue, 25 Jan 2022 09:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574851AbiAYJgt (ORCPT ); Tue, 25 Jan 2022 04:36:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573975AbiAYJa4 (ORCPT ); Tue, 25 Jan 2022 04:30:56 -0500 Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28395C0613EC for ; Tue, 25 Jan 2022 01:30:55 -0800 (PST) Received: by mail-ua1-x92f.google.com with SMTP id w21so36192717uan.7 for ; Tue, 25 Jan 2022 01:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1mm7+Qmz3LImo4aFwbhXIFkzVEgm/HAOzd6fbdAVMrg=; b=kCmCEgQ+xOVJqgvY6mIiDwGpng9RE64Ri/x5bVEJVgfKmrbder8yB0SJa9j3j/iO6u VSlwxJi1GtMfRaX9rz0Fi8V70QZmpTm/yg+yqKEhFTP/kvAigM6NlkG016BHxBuEGBud aKKG3vXyGKhkWECz7g02ij5pN8RBjRbfSAGJhF2s+s/E8Wzq61/RmUZzmkHINs6y38kj 8W/C1tUsfkR71I5xYVxyEgRhxjIz/FmTGO/CwLqL3papla/+aWUpb3kyrOT/GpbDGqeC c1kCPdzAMoEjl9Ka3L/ozlubTR502/GpTZoRLS5kuqKqPkl9NQ2lJSPzTzJVIDppuhpp EfLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1mm7+Qmz3LImo4aFwbhXIFkzVEgm/HAOzd6fbdAVMrg=; b=NSI0eehDIKE1adDcjaWtcq8AUT/9VwRmdVpRAMD1spJwbcUVdlT/bctUGir/gzTORi +6a3MdT/mz/UbEwOmxFf4HrPgCUtV0Ydn5AjkktwtSlZQmDKy3BriyO4a5SDgLXgOXe+ Ju8Bzt4eml6C7uuholMKdgdBJfwXvC+6q8ZNnkQIQ2hFRqRZD3SUeoBRU7X8alClURgH 6ZY7xqg+ME3gvnXaWWXtvVFgfXtTJAPIDXJKaKC7B44azjwRl/FtCKUTs3m8Xd6Uo117 ILWqPL9etwFylx9a4e9WU5uGko9J8hDdumO0XT/w1zrdK4/d5qs8BQw4fUfx1fwvQVmP gqcg== X-Gm-Message-State: AOAM5333dGk+xVDoHmIlUjD35ZWm/DdrmRBSjU+YRIRWHP5z6xhon0M5 YMyfrRr/NN956THzaXkYw+x2rSLp8gxThg/mWBE95g== X-Google-Smtp-Source: ABdhPJwHGGkAwOnsd7qe0zHQAqHAUzi5PBqvJQ90yr1sdZ5zdG5wkLeKm2Z8HhNpFMDsTHL1nOGUCrWQS9pCXlyV9Y0= X-Received: by 2002:a67:8c2:: with SMTP id 185mr712613vsi.19.1643103053912; Tue, 25 Jan 2022 01:30:53 -0800 (PST) MIME-Version: 1.0 References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> From: Lee Jones Date: Tue, 25 Jan 2022 09:30:43 +0000 Message-ID: Subject: Re: [PATCH 0/5] spi: make remove callback a void function To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Mark Brown , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , =?UTF-8?B?TnVubyBTw6E=?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , =?UTF-8?Q?Ronald_Tschal=C3=A4r?= , Marco Felsch , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , =?UTF-8?Q?Stefan_M=C3=A4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de, Noralf Tronnes , Thomas Petazzoni , Guenter Roeck , Enric Balletbo i Serra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org My usual mailer won't let me reply to this many people, so I'm using Gmail. No idea what chaos this will cause, but here goes ... > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- [...] > drivers/mfd/arizona-spi.c | 4 +--- > drivers/mfd/da9052-spi.c | 3 +-- > drivers/mfd/ezx-pcap.c | 4 +--- > drivers/mfd/madera-spi.c | 4 +--- > drivers/mfd/mc13xxx-spi.c | 3 +-- > drivers/mfd/rsmu_spi.c | 4 +--- > drivers/mfd/stmpe-spi.c | 4 +--- > drivers/mfd/tps65912-spi.c | 4 +--- > drivers/video/backlight/ams369fg06.c | 3 +-- > drivers/video/backlight/corgi_lcd.c | 3 +-- > drivers/video/backlight/ili922x.c | 3 +-- > drivers/video/backlight/l4f00242t03.c | 3 +-- > drivers/video/backlight/lms501kf03.c | 3 +-- > drivers/video/backlight/ltv350qv.c | 3 +-- > drivers/video/backlight/tdo24m.c | 3 +-- > drivers/video/backlight/tosa_lcd.c | 4 +--- > drivers/video/backlight/vgg2432a4.c | 4 +--- If it's okay with Mark, it's okay with me. Acked-by: Lee Jones --=20 Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] Linaro Services Principle Technical Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog