From: Sumit Garg <sumit.garg@linaro.org>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
peterhuewe@gmx.de,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
linux-integrity@vger.kernel.org, Arnd Bergmann <arnd@linaro.org>
Subject: Re: [PATCHv5 2/3] optee: use uuid for sysfs driver entry
Date: Mon, 1 Jun 2020 15:47:49 +0530 [thread overview]
Message-ID: <CAFA6WYM3cg2Z2aB=0oO5mp6tXhVtvGZSTr5DTeaBvnpekH8aBA@mail.gmail.com> (raw)
In-Reply-To: <20200529082701.13457-3-maxim.uvarov@linaro.org>
On Fri, 29 May 2020 at 13:57, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> OP-TEE device names for sysfs need to be unique
> and it's better if they will mean something. UUID for name
> looks like good solution:
> /sys/bus/tee/devices/optee-ta-<uuid>
>
I think this description is a little vague here which fails to explain
why we are doing this. How about:
=======
With the evolving use-cases for TEE bus, now it's required to support
multi-stage enumeration process. But using a simple index doesn't
suffice this requirement and instead leads to duplicate sysfs entries.
So instead switch to use more informative device UUID for sysfs entry
like:
/sys/bus/tee/devices/optee-ta-<uuid>
========
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
> Documentation/ABI/testing/sysfs-bus-optee-devices | 8 ++++++++
> MAINTAINERS | 2 ++
> drivers/tee/optee/device.c | 6 +++---
> 3 files changed, 13 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-optee-devices
>
I think this patch belongs as patch #1 in this series given the dependency.
> diff --git a/Documentation/ABI/testing/sysfs-bus-optee-devices b/Documentation/ABI/testing/sysfs-bus-optee-devices
> new file mode 100644
> index 000000000000..0ae04ae5374a
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-optee-devices
> @@ -0,0 +1,8 @@
> +What: /sys/bus/tee/devices/optee-ta-<uuid>/
> +Date: May 2020
> +KernelVersion 5.7
> +Contact: tee-dev@lists.linaro.org
> +Description:
> + OP-TEE bus provides reference to registered drivers under this directory. The <uuid>
> + matches Trusted Application (TA) driver and corresponding TA in secure OS. Drivers
> + are free to create needed API under optee-ta-<uuid> directory.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ecc0749810b0..52717ede29fc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12516,8 +12516,10 @@ OP-TEE DRIVER
> M: Jens Wiklander <jens.wiklander@linaro.org>
> L: tee-dev@lists.linaro.org
> S: Maintained
> +F: Documentation/ABI/testing/sysfs-bus-optee-devices
> F: drivers/tee/optee/
>
> +
Unnecessary blank line.
-Sumit
> OP-TEE RANDOM NUMBER GENERATOR (RNG) DRIVER
> M: Sumit Garg <sumit.garg@linaro.org>
> L: tee-dev@lists.linaro.org
> diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c
> index d4931dad07aa..2eb1c0283aec 100644
> --- a/drivers/tee/optee/device.c
> +++ b/drivers/tee/optee/device.c
> @@ -65,7 +65,7 @@ static int get_devices(struct tee_context *ctx, u32 session,
> return 0;
> }
>
> -static int optee_register_device(const uuid_t *device_uuid, u32 device_id)
> +static int optee_register_device(const uuid_t *device_uuid)
> {
> struct tee_client_device *optee_device = NULL;
> int rc;
> @@ -75,7 +75,7 @@ static int optee_register_device(const uuid_t *device_uuid, u32 device_id)
> return -ENOMEM;
>
> optee_device->dev.bus = &tee_bus_type;
> - dev_set_name(&optee_device->dev, "optee-clnt%u", device_id);
> + dev_set_name(&optee_device->dev, "optee-ta-%pUl", device_uuid);
> uuid_copy(&optee_device->id.uuid, device_uuid);
>
> rc = device_register(&optee_device->dev);
> @@ -144,7 +144,7 @@ static int __optee_enumerate_devices(u32 func)
> num_devices = shm_size / sizeof(uuid_t);
>
> for (idx = 0; idx < num_devices; idx++) {
> - rc = optee_register_device(&device_uuid[idx], idx);
> + rc = optee_register_device(&device_uuid[idx]);
> if (rc)
> goto out_shm;
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-01 10:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:26 [PATCHv5 0/3] optee: register drivers on optee bus Maxim Uvarov
2020-05-29 8:26 ` [PATCHv5 1/3] optee: do drivers initialization before and after tee-supplicant run Maxim Uvarov
2020-06-01 1:49 ` Jarkko Sakkinen
2020-06-01 7:13 ` Maxim Uvarov
2020-06-01 7:59 ` Jarkko Sakkinen
2020-06-01 10:45 ` Sumit Garg
2020-05-29 8:27 ` [PATCHv5 2/3] optee: use uuid for sysfs driver entry Maxim Uvarov
2020-06-01 10:17 ` Sumit Garg [this message]
2020-05-29 8:27 ` [PATCHv5 3/3] tpm_ftpm_tee: register driver on TEE bus Maxim Uvarov
2020-06-01 11:11 ` Sumit Garg
2020-06-01 14:06 ` Maxim Uvarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFA6WYM3cg2Z2aB=0oO5mp6tXhVtvGZSTr5DTeaBvnpekH8aBA@mail.gmail.com' \
--to=sumit.garg@linaro.org \
--cc=arnd@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jens.wiklander@linaro.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@linaro.org \
--cc=peterhuewe@gmx.de \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).