From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499A8C433FF for ; Thu, 8 Aug 2019 13:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2152421882 for ; Thu, 8 Aug 2019 13:21:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VnEIalSf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389843AbfHHNVy (ORCPT ); Thu, 8 Aug 2019 09:21:54 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:38033 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389844AbfHHNVw (ORCPT ); Thu, 8 Aug 2019 09:21:52 -0400 Received: by mail-lf1-f67.google.com with SMTP id h28so66781362lfj.5 for ; Thu, 08 Aug 2019 06:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yPRSbt/ERroXQ3CLHiXg6WnTxTB+hRN/pv9SKNLhs4Y=; b=VnEIalSfu0SZj1Vm/7X2ReQgboUTXdytq3Ju8ZMCLD0t3tVftiaZQuk+TGh7D/LUAa gaJaZK+auUmyKPLOORwZmJFQiOa1ihPZgxLYmqTdU8rB/57WqFu9TtOa5uA20I7UgE+3 hlphlO0UxK7JErrmwkGtDe4+fieeQpbxTcEr9701DA3NfDdfJaSMaDWW6uMdHChjnTxs c7obhEnph33x5gT/xTjbhUcev8i0z9IHueN7LM/Nj0+821pA2r/BLVCjqtKE7qdaOENC ts+fBmh/V6Fk09XKlbD70WrSjLEs1MNWTmkYJYa4UFM30KkQvAf/nYNhcMDAvtHbjAzX tcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yPRSbt/ERroXQ3CLHiXg6WnTxTB+hRN/pv9SKNLhs4Y=; b=VI6X/YGWSs1jzP7y5q7W5sr0HlMZd1/Jn8qmh6g19N+cPTHesGMXmQZgimPlbAXm44 mzV6XiLTZXFBNL0lBgTN0ETSrAzZfgVXaU675rDZRjFu4zWgU086pbkqOvwhSSxg0uu9 4SNrBRfKfzXsW0gu8d28oVDTqaQPfWqBW7lsrIlhkN2fzjk+Stwvmi+lXZIAhgk9IhMu kDIBW89mZbhALm+aKviirWyTzV62xB55qK+r5KNekHsLHjBCXpCQ6UMLWyTBb7B45UVj P4T6zDvNsZI7chZXABtCrw4XwHOHDBeMWLTUjQ68L3JommfsqP6nmaZ9feJF/i1CkBfR lmxA== X-Gm-Message-State: APjAAAWQeD5OHvQ24ioYANVE5beLDbR2nAInX868qbiYlu1P+dlwBJxS aH1sba6f/cD+0izCPN9eHb2bG0IuZ43FZ2G1whFwyg== X-Google-Smtp-Source: APXvYqw4VebWjEwpo3i9J0LRc5h0s+ynpfKok3QYD7qKC4/j06X+QGgIcDtFC+QCcnhYJmwAPh6zR54jEVVZOZgyJm8= X-Received: by 2002:ac2:4901:: with SMTP id n1mr9552721lfi.0.1565270510135; Thu, 08 Aug 2019 06:21:50 -0700 (PDT) MIME-Version: 1.0 References: <1565098640-12536-1-git-send-email-sumit.garg@linaro.org> <1565098640-12536-3-git-send-email-sumit.garg@linaro.org> <20190807190320.th4sbnsnmwb7myzx@linux.intel.com> In-Reply-To: <20190807190320.th4sbnsnmwb7myzx@linux.intel.com> From: Sumit Garg Date: Thu, 8 Aug 2019 18:51:38 +0530 Message-ID: Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code To: Jarkko Sakkinen Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-security-module@vger.kernel.org, dhowells@redhat.com, Herbert Xu , davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, Arnd Bergmann , Greg Kroah-Hartman , Mimi Zohar , James Morris , "Serge E. Hallyn" , Casey Schaufler , Ard Biesheuvel , Daniel Thompson , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 8 Aug 2019 at 00:33, Jarkko Sakkinen wrote: > > On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. > > Missing a long description. The reason is that it is better consolidate > all trusted keys code to a single location so that it can be maintained > sanely and it should be stated here. Sure will extend the description. > > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Sumit Garg > > I would suggest adding at least two commits before this: > > - A commit that just exports tpm_buf stuff and TPM2 constants to > include/linux Okay, will create a separate patch for this. > - A commit that just changes the existing TPM 1.x trusted keys > code to use tpm_buf. It seems to be a functional change which I think requires proper unit testing. I am afraid that I don't posses a TPM device to test this and also very less conversant with tpm_buf code. So what I have done here is to rename existing TPM 1.x trusted keys code to use tpm1_buf. And I would be happy to integrate a tested patch if anyone familiar could work on this. -Sumit > > These should be before the current 1/3 commit. > > /Jarkko