From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FD1C31E40 for ; Tue, 6 Aug 2019 13:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D51D214C6 for ; Tue, 6 Aug 2019 13:55:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gDftQyU1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729161AbfHFNz3 (ORCPT ); Tue, 6 Aug 2019 09:55:29 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:33217 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbfHFNzZ (ORCPT ); Tue, 6 Aug 2019 09:55:25 -0400 Received: by mail-lf1-f66.google.com with SMTP id x3so61317654lfc.0 for ; Tue, 06 Aug 2019 06:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=416ovtRseB2pZqvtmfp0MPISej3Ly1ggyhuXKFA1TSc=; b=gDftQyU1sPLNDej0wqOudB1zkk8RWR8GaBumdUmuN1ITOuIMv6D184qQCjXC2BONd5 5vqAH8nQ1i61o5WZKQqN3Ed4at81eZcE6pSsx1nf/ywXDy1Q/9CGHvZKHuIodIOfBuWx VwQ19fUMCt8gIbT1VdEX7+mvkWYJuO9qJ4cz9kRNbfF7ufzFj9CsH6Wv2vvnpqWCl/24 e7FaiAo+HHBnWEvkt2QsYiXs/P25XMi38nnDymc7XFlY2NiOXo6uTcCd9Aud+bq08rgH 31Z/k5NNVcW4wN+P3YtazLFd82nhrnIqxbwG+nhaDOO2bY0OaoEi77I/o7bKQFyhCg2L IAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=416ovtRseB2pZqvtmfp0MPISej3Ly1ggyhuXKFA1TSc=; b=qo18IWrWnCkDNbWppmzPxege8vksGevaTEWCLu5RpTOfzYhGIA4VdVCozvQTMzP4BS 0QVlJ6oK9IICCETxIg7Q3vQt8AvvrgXS+izfL0ofKqWyPX13QBX/SiCxBhpK/SpsEEF0 n3jvzCgHqvIZTop8zQ5rTMSVP1D2DrhSgXAKItWuwbYQ2q1+j53Hz5l+u1ANKbowUqny oiDdor2vrZjXH0Cc+egNLtcih7suDSWsqNSN/YezqHJlJiVISAZ3dlolhIvWnAb4Dm4O xQMdpJ035hSPjsDi0uaztNI6+Cg0S3RVyma/cC3fsRBlc7gFner/+phi2HTL7+VbfEWl gbrw== X-Gm-Message-State: APjAAAVo8Wgq0ZWUdBUdQAtB/TuJKOhwmIneZ5XM/I0Y0S3lER9cNpTa Mg/hqKfwPpwggEYqCDQvnG2U/z4wIesxR2/dSJ1PNA== X-Google-Smtp-Source: APXvYqyDhk3mM2mXFVY+5NaLG5MnfeslEX98rS822FuxZkz+Chdgp4KVCeTC7L8SPh116s2rDNgHQ7ixop5FDBZ38Q4= X-Received: by 2002:ac2:5637:: with SMTP id b23mr2634100lff.186.1565099723639; Tue, 06 Aug 2019 06:55:23 -0700 (PDT) MIME-Version: 1.0 References: <1565098640-12536-1-git-send-email-sumit.garg@linaro.org> <1565098640-12536-3-git-send-email-sumit.garg@linaro.org> <20190806134322.GA10783@kroah.com> In-Reply-To: <20190806134322.GA10783@kroah.com> From: Sumit Garg Date: Tue, 6 Aug 2019 19:25:12 +0530 Message-ID: Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code To: Greg KH Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-security-module@vger.kernel.org, dhowells@redhat.com, Herbert Xu , davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, Jarkko Sakkinen , Arnd Bergmann , Mimi Zohar , James Morris , "Serge E. Hallyn" , Casey Schaufler , Ard Biesheuvel , Daniel Thompson , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, 6 Aug 2019 at 19:13, Greg KH wrote: > > On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. > > > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Sumit Garg > > --- > > drivers/char/tpm/tpm-interface.c | 56 ----- > > drivers/char/tpm/tpm.h | 224 ------------------ > > drivers/char/tpm/tpm2-cmd.c | 307 ------------------------ > > include/keys/trusted_tpm.h | 23 +- > > include/linux/tpm.h | 264 +++++++++++++++++++-- > > security/keys/trusted-keys/Makefile | 3 +- > > security/keys/trusted-keys/trusted-tpm.c | 16 +- > > security/keys/trusted-keys/trusted-tpm2.c | 378 ++++++++++++++++++++++++++++++ > > 8 files changed, 652 insertions(+), 619 deletions(-) > > create mode 100644 security/keys/trusted-keys/trusted-tpm2.c > > 'git format-patch -M' will create a patch that shows the rename, and > then any tiny differences that happened after that. A patch like this > is hard to see what changed in the move. > I used this option only to generate the patch-set. Following is the command I used: git format-patch -M -3 --cover-letter --subject-prefix="RFC/RFT v3" It seems like for this patch I need to collect pieces from "drivers/char/tpm/" and aggregate them under "security/keys/trusted-keys/trusted-tpm2.c" and "include/linux/tpm.h" files. So that could be the reason for such patch view. -Sumit > thanks, > > greg k-h