From: Sumit Garg <sumit.garg@linaro.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.ibm.com>,
James Bottomley <jejb@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Jens Wiklander <jens.wiklander@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Janne Karhunen <janne.karhunen@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Markus Wamser <Markus.Wamser@mixed-mode.de>,
Luke Hinds <lhinds@redhat.com>,
"open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>,
linux-integrity@vger.kernel.org,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework
Date: Mon, 15 Feb 2021 18:45:37 +0530 [thread overview]
Message-ID: <CAFA6WYPrNPMZFA+u0fMo8T1DBFxu6XAVC4KySP53BarjDhfBQA@mail.gmail.com> (raw)
In-Reply-To: <YCQRPo0o6MZ0pcUa@kernel.org>
On Wed, 10 Feb 2021 at 22:30, Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> On Tue, Nov 03, 2020 at 09:31:43PM +0530, Sumit Garg wrote:
> > + case Opt_new:
> > + key_len = payload->key_len;
> > + ret = static_call(trusted_key_get_random)(payload->key,
> > + key_len);
> > + if (ret != key_len) {
> > + pr_info("trusted_key: key_create failed (%d)\n", ret);
> > + goto out;
> > + }
>
> This repeats a regression in existing code, i.e. does not check
> "ret < 0" condition. I noticed this now when I rebased the code
> on top of my fixes.
>
> I.e. it's fixed in my master branch, which caused a merge conflict,
> and I found this.
>
Okay, I will rebase the next version to your master branch.
-Sumit
> /Jarkko
next prev parent reply other threads:[~2021-02-15 13:16 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 16:01 [PATCH v8 0/4] Introduce TEE based Trusted Keys support Sumit Garg
2020-11-03 16:01 ` [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2020-11-24 3:42 ` Jarkko Sakkinen
2021-02-15 13:13 ` Sumit Garg
2021-02-10 17:00 ` Jarkko Sakkinen
2021-02-11 10:34 ` Ahmad Fatoum
2021-02-12 12:22 ` Jarkko Sakkinen
2021-02-15 13:15 ` Sumit Garg [this message]
2020-11-03 16:01 ` [PATCH v8 2/4] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2020-11-24 3:46 ` Jarkko Sakkinen
2021-01-11 16:35 ` Jarkko Sakkinen
2021-01-13 11:17 ` Sumit Garg
2021-01-14 2:05 ` Jarkko Sakkinen
2021-01-15 6:02 ` Sumit Garg
2021-01-19 10:30 ` Jarkko Sakkinen
2021-01-20 1:31 ` Jarkko Sakkinen
2021-01-20 7:23 ` Sumit Garg
2021-01-21 0:01 ` Jarkko Sakkinen
[not found] ` <01000177223f74d3-1eef7685-4a19-40d2-ace6-d4cd7f35579d-000000@email.amazonses.com>
2021-01-21 8:44 ` Jerome Forissier
2021-01-21 15:07 ` Jarkko Sakkinen
2021-01-21 15:24 ` Jarkko Sakkinen
2021-01-21 16:23 ` Jerome Forissier
2021-01-22 18:12 ` Jarkko Sakkinen
[not found] ` <CAFA6WYPQ+LZyHKZJQb=3euTy8f8TO3HqCADojpZaHXgtzNj+fw@mail.gmail.com>
2021-01-27 17:14 ` Jarkko Sakkinen
2021-01-27 17:19 ` Jarkko Sakkinen
2021-02-04 0:05 ` Jarkko Sakkinen
2021-02-11 23:34 ` Jarkko Sakkinen
2021-02-11 23:35 ` Jarkko Sakkinen
2021-02-15 13:07 ` Sumit Garg
2021-02-16 7:29 ` Jarkko Sakkinen
2021-02-22 7:15 ` Sumit Garg
2021-02-24 16:58 ` Jarkko Sakkinen
2021-01-20 13:36 ` Ahmad Fatoum
2020-11-03 16:01 ` [PATCH v8 3/4] doc: trusted-encrypted: updates with TEE as a new trust source Sumit Garg
2020-12-02 19:34 ` gmail Elaine Palmer
2020-12-04 15:30 ` Jarkko Sakkinen
2020-12-08 15:02 ` Mimi Zohar
2020-12-08 17:49 ` Jarkko Sakkinen
2020-12-09 16:50 ` Mimi Zohar
2020-12-11 10:36 ` Jarkko Sakkinen
2020-12-11 15:29 ` Mimi Zohar
2020-12-06 18:51 ` Randy Dunlap
2020-12-08 15:55 ` Mimi Zohar
2020-12-08 17:07 ` Mimi Zohar
2020-11-03 16:01 ` [PATCH v8 4/4] MAINTAINERS: Add myself as Trusted Keys co-maintainer Sumit Garg
2020-11-24 3:46 ` Jarkko Sakkinen
2020-11-05 5:07 ` [PATCH v8 0/4] Introduce TEE based Trusted Keys support Jarkko Sakkinen
2020-11-06 9:32 ` Sumit Garg
2020-11-06 14:52 ` Jarkko Sakkinen
2020-12-04 5:16 ` Jarkko Sakkinen
2020-12-08 11:51 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFA6WYPrNPMZFA+u0fMo8T1DBFxu6XAVC4KySP53BarjDhfBQA@mail.gmail.com \
--to=sumit.garg@linaro.org \
--cc=Markus.Wamser@mixed-mode.de \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dhowells@redhat.com \
--cc=janne.karhunen@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jens.wiklander@linaro.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=lhinds@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).