From: Lukasz Majczak <lma@semihalf.com>
To: Laurent Bigonville <bigon@debian.org>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
linux-integrity@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.ibm.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: Re: [PATCH] tpm, tpm_tis: Acquire locality in tpm_tis_gen_interrupt() and tpm_get_timeouts()
Date: Tue, 16 Feb 2021 15:09:49 +0100 [thread overview]
Message-ID: <CAFJ_xbooQp5FqEuSGu3ChqdKj0YfLzfhLYMYUDfOiQ+vaVnOdw@mail.gmail.com> (raw)
In-Reply-To: <ccb8ff69-5223-c293-bdda-46f041b7b770@debian.org>
Hi Laurent,
I think your case is different, as the trace shows the issue occurs in
the place already guarded by tpm_chip_start()/stop() - tpm2_probe().
Can you paste more dmesg log? (With tpm prefix?). I believe
tpm_tis_status() might return something different than 0xff here.
Please ensure you have applied Jarkko's patch that logs status
(https://patchwork.kernel.org/project/linux-integrity/patch/20210202222150.120664-1-jarkko@kernel.org/)
Best regards
Lukasz
wt., 16 lut 2021 o 12:02 Laurent Bigonville <bigon@debian.org> napisał(a):
>
> Le 16/02/21 à 09:17, Jarkko Sakkinen a écrit :
> > From: Lukasz Majczak <lma@semihalf.com>
> >
> > This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
> > (SLB 9670):
> >
> > [ 4.324298] TPM returned invalid status
> > [ 4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f
> >
> > Background
> > ==========
> >
> > TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
> > Interface Locality Usage per Register, Table 39 Register Behavior Based on
> > Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
> > 0xFF in case of lack of locality. The described situation manifests itself
> > with the following warning trace:
> >
> > The fix
> > =======
> >
> > Add the proper decorations to tpm_tis_gen_interrupt() and
> > tpm_get_timeouts().
>
> I tried that patch (alone on the top of the HEAD of Linus master) and I
> still get the same trace in dmesg
>
next prev parent reply other threads:[~2021-02-16 14:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 8:17 [PATCH] tpm, tpm_tis: Acquire locality in tpm_tis_gen_interrupt() and tpm_get_timeouts() Jarkko Sakkinen
2021-02-16 8:26 ` Paul Menzel
2021-02-16 8:39 ` Jarkko Sakkinen
2021-02-16 8:50 ` Paul Menzel
2021-02-16 16:14 ` Jarkko Sakkinen
2021-02-16 11:02 ` Laurent Bigonville
[not found] ` <CAFJ_xbo2Tvfjjbt-xFAkEAdqVEg0ZhDnGJa2qkJOYURx47hE+Q@mail.gmail.com>
2021-02-16 11:21 ` Laurent Bigonville
2021-02-16 14:09 ` Lukasz Majczak [this message]
2021-02-16 16:18 ` Jarkko Sakkinen
2021-02-16 16:16 ` Jarkko Sakkinen
2021-02-16 16:26 ` Jarkko Sakkinen
2021-02-16 16:34 ` Jarkko Sakkinen
2021-02-16 19:06 ` Laurent Bigonville
2021-02-17 11:51 ` Lukasz Majczak
2021-02-17 22:29 ` Jarkko Sakkinen
2021-06-01 21:17 ` Laurent Bigonville
2021-06-03 5:28 ` Jarkko Sakkinen
2021-06-03 9:42 ` Laurent Bigonville
2021-06-09 12:43 ` Jarkko Sakkinen
2021-06-10 11:35 ` Laurent Bigonville
2021-06-10 12:29 ` Jarkko Sakkinen
2021-06-10 14:00 ` Laurent Bigonville
2021-06-14 20:40 ` Jarkko Sakkinen
2021-06-15 11:19 ` Laurent Bigonville
2021-06-15 12:56 ` Jarkko Sakkinen
2021-06-15 16:27 ` Laurent Bigonville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFJ_xbooQp5FqEuSGu3ChqdKj0YfLzfhLYMYUDfOiQ+vaVnOdw@mail.gmail.com \
--to=lma@semihalf.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bigon@debian.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).