From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3FCFC761AF for ; Fri, 24 Mar 2023 14:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbjCXOR1 (ORCPT ); Fri, 24 Mar 2023 10:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjCXOR0 (ORCPT ); Fri, 24 Mar 2023 10:17:26 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6881EFE8 for ; Fri, 24 Mar 2023 07:17:20 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id p203so2286870ybb.13 for ; Fri, 24 Mar 2023 07:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1679667440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qyz70q0exwlxpG0yMPJfrMAVsSG+06PVBNztaJhtJqo=; b=AOQvr9b4IDlun2P9WBqyFgYrZnRMnWkZbi7nKD1h77svDtysp3k2+svumSz94wRohI DHZZwnayCvXPboUZHbIPyaInyWGXe1MZU80EoiXvTGptGU5x9ycbCOmJQPEv5+ToeKhI M28EIQd9BR39cjtGdwuyZiW6Z7sHOCN3XEb/+rDt/zaSbv28B5BeAQweq/nnqcNzKhfQ 8dNPfrfNpTMGHcndWQbl5qRBpRC+A5GBdNdTaoP1dpsA4MjG2imDAtn4mnZCDF0V7zF9 v0rIKu1s/EOQIUsfRTFmsVupWgV2UUt+PQt8qEAWmu6B4mKm/O6meI3joa44DP3+Dbq0 WgiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679667440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qyz70q0exwlxpG0yMPJfrMAVsSG+06PVBNztaJhtJqo=; b=elKTpRsxcHzSR1qjb04/fx/DHx/nYZWqccu2ByzNI/iFQJgIvG1BeKG7oHVV1XQUmC oM6IiqfE7zoa7YpcIOQ+4z1ik34wj4KZzNATU09NOoVyojZxzx/O4xyeXff3HgXeZ8Xn LauJoibmZ9wYpq9gB06bb3NWZ2zUYsNqE1uKF1Czo7QjlHh7dHg0fL+Z+CGcGvWSaY0o hGuj4yOpCpIbH2Ym8e0kI6Qp61OJqSQkiV2oJSAew7go/TDN/vEOTTkckHSS+YUX1V9g 9xe/zhLR75GddPgkiUWFh/Dw2tNvkn93PTqAN/gHhNZxy03DCH0iFfvO1mxIGB41VzNg dTzw== X-Gm-Message-State: AAQBX9ejae5WH8PYI1pYKU7iOGVSprcA4lQe1RfnXZZJpT5QIA4837d6 rA3Zp6vdn/A60+MHUjglw4j1rUe1R1KjQ53xZxyl X-Google-Smtp-Source: AKy350amz4iSWC/J6MBpFaFbKcK0anHYtISoEVuIwiCetg7GwG+iRm9rYxlweWMrGHUcXR2/Z4SwCvWYK/Z/pHw7RwU= X-Received: by 2002:a05:6902:1586:b0:b76:ceb2:661b with SMTP id k6-20020a056902158600b00b76ceb2661bmr1495681ybu.3.1679667440030; Fri, 24 Mar 2023 07:17:20 -0700 (PDT) MIME-Version: 1.0 References: <20230314081720.4158676-1-roberto.sassu@huaweicloud.com> <20230314081720.4158676-5-roberto.sassu@huaweicloud.com> <5d8d802a-7664-fdf0-52ef-5817634d870d@schaufler-ca.com> In-Reply-To: <5d8d802a-7664-fdf0-52ef-5817634d870d@schaufler-ca.com> From: Paul Moore Date: Fri, 24 Mar 2023 10:17:09 -0400 Message-ID: Subject: Re: [PATCH v8 4/6] security: Allow all LSMs to provide xattrs for inode_init_security hook To: Casey Schaufler Cc: Roberto Sassu , mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Mar 23, 2023 at 9:01=E2=80=AFPM Casey Schaufler wrote: > On 3/23/2023 5:09 PM, Paul Moore wrote: > > On Tue, Mar 14, 2023 at 4:19=E2=80=AFAM Roberto Sassu > > wrote: ... > >> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h > >> index c2be66c669a..75a2f85b49d 100644 > >> --- a/include/linux/lsm_hooks.h > >> +++ b/include/linux/lsm_hooks.h > >> @@ -63,6 +63,7 @@ struct lsm_blob_sizes { > >> int lbs_ipc; > >> int lbs_msg_msg; > >> int lbs_task; > >> + int lbs_xattr; /* number of xattr slots in new_xattrs arra= y */ > > > > No need for the comment, we don't do it for the other fields. > > I asked for the comment. lbs_xattr is the number of entries, which is > different from the other fields. The other fields contain blob sizes in > bytes. Inconsistent behavior should be noted. Fair enough. Since that's the case, let's encode something in the field name itself so that every user has a slight reminder that it is a count and not a size. How about 'lbs_xattr_count' or similar? --=20 paul-moore.com