From: Seunghun Han <kkamagui@gmail.com>
To: ivan.lazeev@gmail.com
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de
Subject: Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs
Date: Wed, 11 Sep 2019 14:17:48 +0900 [thread overview]
Message-ID: <CAHjaAcStAfarJoPG0tbSY0BVcp0-7Lvah2FdpmC_eCFfxaSVFw@mail.gmail.com> (raw)
> > And why is this allocating memory inside the acpi table walker? It
> > seems to me like the memory should be allocated once the mapping is
> > made.
> >
>
> Yes, this looks bad. Letting the walker build the list and then using
> it is, probably, a better idea.
>
> > Maybe all the mappings should be created from the ACPI ranges right
> > away?
> >
>
> I don't know if it's a good idea to just map them all instead of doing
> so only for relevant ones. Maybe it is safe, here I need an advice
> from a more knowledgeable person.
>
Vanya,
I also made a patch series to solve AMD's fTPM. My patch link is here,
https://lkml.org/lkml/2019/9/9/132 .
The maintainer, Jarkko, wanted me to remark on your patch, so I would
like to cooperate with you.
Your patch is good for me. If you are fine, I would like to take your
patch and merge it with my patch series. I also would like to change
some points Jason mentioned before.
Of course, I will leave your commit message and sign-off-by note.
According to the guideline below, I will just add co-developed-by and
sign-off-by notes behind you.
https://www.kernel.org/doc/html/v5.2/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
If you have any idea about our co-work, please let me know.
I hope we can solve AMD's fTPM problem soon.
Seunghun
next reply other threads:[~2019-09-11 5:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 5:17 Seunghun Han [this message]
2019-09-13 14:00 ` [PATCH v2] Fix fTPM on AMD Zen+ CPUs Jarkko Sakkinen
2019-09-13 14:02 ` Jarkko Sakkinen
2019-09-16 5:29 ` Seunghun Han
2019-09-16 9:07 ` Jarkko Sakkinen
2019-09-16 9:43 ` Seunghun Han
-- strict thread matches above, loose matches on Subject: below --
2019-08-11 18:52 ivan.lazeev
2019-08-12 13:10 ` Jason Gunthorpe
2019-08-12 22:42 ` Vanya Lazeev
2019-08-15 20:47 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHjaAcStAfarJoPG0tbSY0BVcp0-7Lvah2FdpmC_eCFfxaSVFw@mail.gmail.com \
--to=kkamagui@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.lazeev@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).