From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8284C169C4 for ; Thu, 31 Jan 2019 19:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A7442086C for ; Thu, 31 Jan 2019 19:10:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WSdZg3Gg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbfAaTKn (ORCPT ); Thu, 31 Jan 2019 14:10:43 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:40607 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbfAaTKm (ORCPT ); Thu, 31 Jan 2019 14:10:42 -0500 Received: by mail-lf1-f65.google.com with SMTP id v5so3185126lfe.7 for ; Thu, 31 Jan 2019 11:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xscg+IDwK+piZ4gwM9pr76+iGnilAL9l9sUJBQ14ql4=; b=WSdZg3GgdCf+Bfnb/A+u6kK/WpovsTeVodF2/V5GuUcUeDkcXBt+Io4wfbZtEB10pR uWykPgozcSi9R+lsNeRiDIVXAhIHyaJlu4Q34fAMU6DMQ98fuJ7fIiolhm9S2/Dez8oN do5hjWbqseBMjJJBGiVlLhgtJtFN6ap3qboak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xscg+IDwK+piZ4gwM9pr76+iGnilAL9l9sUJBQ14ql4=; b=FtZ4ia5iSg29IOL9zgRBT3w6bwG/+2Te+6eiDlf4ojJq+ew7z+uNDG3eFq0vrwQxtl vbDn5IFhq3DDnOLC7Xdlv9BXevLSw0bMMKh9/dlhdC/R2/psYGVBqJ4HV0DsGToxPx3l eKyp4Qdwp4dJlEMdIkZOSRm7wMkNozTB7xw+vR6p4wiVXfZCY8Qm6f7EcH0OmMyGfXyG crG0OyQOtIFT14+rADCkCI3JJOc+3Ya+52O9B1cfGJ+eIE7tJ5ky/70j4qPWP8Wtuu5x jYFtPlhkkg6Mywv+/3KuxopmRYULujpEQhVoPlmuLWEioas+y5J2C4nt7IrEIxez7YU/ oDOw== X-Gm-Message-State: AJcUukfoz6ViSRxA5VuXK416FImFttO/2Y+XbRldTpHcEWAUrMWR6ZLF IRgBYzMVSFGfM0fSMnvWpgM0wMpmmRw= X-Google-Smtp-Source: ALg8bN5SqypBtvoqKzgi+EKmT+Sa5Len738YJSTsSqWAYmeXLrKxyZN+vM0yrfGQin2yW+aOuepqCA== X-Received: by 2002:a19:8c1b:: with SMTP id o27mr27264833lfd.90.1548961839535; Thu, 31 Jan 2019 11:10:39 -0800 (PST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id e19-v6sm928110ljf.67.2019.01.31.11.10.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 11:10:37 -0800 (PST) Received: by mail-lj1-f173.google.com with SMTP id x85-v6so3675115ljb.2 for ; Thu, 31 Jan 2019 11:10:37 -0800 (PST) X-Received: by 2002:a2e:880a:: with SMTP id x10-v6mr30717208ljh.174.1548961837166; Thu, 31 Jan 2019 11:10:37 -0800 (PST) MIME-Version: 1.0 References: <20190122010218.GA26713@linux.intel.com> <20190122025836.GH25163@ziepe.ca> <20190122132910.GA2720@linux.intel.com> <20190123153638.GA8727@linux.intel.com> <20190129132016.GA1602@linux.intel.com> <20190131122606.GA12470@linux.intel.com> <20190131160437.GA5629@linux.intel.com> <20190131170603.GA18349@linux.intel.com> <20190131183530.GA27112@linux.intel.com> In-Reply-To: From: Linus Torvalds Date: Thu, 31 Jan 2019 11:10:20 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Getting weird TPM error after rebasing my tree to security/next-general To: Jarkko Sakkinen Cc: tomas.winkler@intel.com, Jason Gunthorpe , James Bottomley , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux List Kernel Mailing Content-Type: multipart/mixed; boundary="000000000000136afa0580c5c8f2" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org --000000000000136afa0580c5c8f2 Content-Type: text/plain; charset="UTF-8" On Thu, Jan 31, 2019 at 10:52 AM Linus Torvalds wrote: > > I think what I should do is to just make "memcpy_*io()" do the "align > naturally" thing. > > Let me cook up a patch for you to test. Does this work for you? I haven't tested it at all, but I verified that the generated code seems to make at least some amount of sense. Linus --000000000000136afa0580c5c8f2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrkzvf6d0 IGFyY2gveDg2L2xpYi9pb21lbS5jIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9hcmNoL3g4Ni9saWIvaW9tZW0uYyBiL2FyY2gveDg2L2xpYi9pb21lbS5jCmluZGV4IDY2 ODk0Njc1ZjNjOC4uN2I1YjA3ZjNkMzcwIDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9saWIvaW9tZW0u YworKysgYi9hcmNoL3g4Ni9saWIvaW9tZW0uYwpAQCAtMyw3ICszLDcgQEAKICNpbmNsdWRlIDxs aW51eC9pby5oPgogCiAvKiBPcmlnaW5hbGx5IGZyb20gaTM4Ni9zdHJpbmcuaCAqLwotc3RhdGlj IF9fYWx3YXlzX2lubGluZSB2b2lkIF9faW9tZW1fbWVtY3B5KHZvaWQgKnRvLCBjb25zdCB2b2lk ICpmcm9tLCBzaXplX3QgbikKK3N0YXRpYyBfX2Fsd2F5c19pbmxpbmUgdm9pZCByZXBfbW92cyh2 b2lkICp0bywgY29uc3Qgdm9pZCAqZnJvbSwgc2l6ZV90IG4pCiB7CiAJdW5zaWduZWQgbG9uZyBk MCwgZDEsIGQyOwogCWFzbSB2b2xhdGlsZSgicmVwIDsgbW92c2xcblx0IgpAQCAtMTksMTUgKzE5 LDM2IEBAIHN0YXRpYyBfX2Fsd2F5c19pbmxpbmUgdm9pZCBfX2lvbWVtX21lbWNweSh2b2lkICp0 bywgY29uc3Qgdm9pZCAqZnJvbSwgc2l6ZV90IG4pCiAJCSAgICAgOiAibWVtb3J5Iik7CiB9CiAK KyNkZWZpbmUgbW92cyh0eXBlLHRvLGZyb20pIFwKKwlhc20gdm9sYXRpbGUoIm1vdnMiIHR5cGU6 Ij0mRCIgKHRvKSwgIj0mUyIgKGZyb20pOiIwIiAodG8pLCAiMSIgKGZyb20pOiJtZW1vcnkiKQor CiB2b2lkIG1lbWNweV9mcm9taW8odm9pZCAqdG8sIGNvbnN0IHZvbGF0aWxlIHZvaWQgX19pb21l bSAqZnJvbSwgc2l6ZV90IG4pCiB7Ci0JX19pb21lbV9tZW1jcHkodG8sIChjb25zdCB2b2lkICop ZnJvbSwgbik7CisJLyogVW5hbGlnbmVkIElPPyAqLworCWlmIChuICYmIHVubGlrZWx5KDEgJiAo dW5zaWduZWQgbG9uZylmcm9tKSkgeworCQltb3ZzKCJiIiwgdG8sIGZyb20pOworCQluLS07CisJ fQorCWlmIChuID4gMSAmJiB1bmxpa2VseSgyICYgKHVuc2lnbmVkIGxvbmcpZnJvbSkpIHsKKwkJ bW92cygidyIsIHRvLCBmcm9tKTsKKwkJbi09MjsKKwl9CisJcmVwX21vdnModG8sIChjb25zdCB2 b2lkICopZnJvbSwgbik7CiB9CiBFWFBPUlRfU1lNQk9MKG1lbWNweV9mcm9taW8pOwogCiB2b2lk IG1lbWNweV90b2lvKHZvbGF0aWxlIHZvaWQgX19pb21lbSAqdG8sIGNvbnN0IHZvaWQgKmZyb20s IHNpemVfdCBuKQogewotCV9faW9tZW1fbWVtY3B5KCh2b2lkICopdG8sIChjb25zdCB2b2lkICop IGZyb20sIG4pOworCS8qIFVuYWxpZ25lZCBJTz8gKi8KKwlpZiAobiAmJiB1bmxpa2VseSgxICYg KHVuc2lnbmVkIGxvbmcpdG8pKSB7CisJCW1vdnMoImIiLCB0bywgZnJvbSk7CisJCW4tLTsKKwl9 CisJaWYgKG4gPiAxICYmIHVubGlrZWx5KDIgJiAodW5zaWduZWQgbG9uZyl0bykpIHsKKwkJbW92 cygidyIsIHRvLCBmcm9tKTsKKwkJbi09MjsKKwl9CisJcmVwX21vdnMoKHZvaWQgKil0bywgKGNv bnN0IHZvaWQgKikgZnJvbSwgbik7CiB9CiBFWFBPUlRfU1lNQk9MKG1lbWNweV90b2lvKTsKIAo= --000000000000136afa0580c5c8f2--