From: Amir Goldstein <amir73il@gmail.com>
To: Ignaz Forster <iforster@suse.com>
Cc: Mimi Zohar <zohar@linux.ibm.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>,
Fabian Vogt <fvogt@suse.com>, Ignaz Forster <iforster@suse.de>,
Fabian Vogt <fvogt@suse.de>
Subject: Re: [PATCH 4/5] Ignore IMA / EVM xattrs during copy_up
Date: Tue, 12 Feb 2019 04:55:45 +0200 [thread overview]
Message-ID: <CAOQ4uxhrGtPxUVBfxoiGLh_5+qktC_0CC+CaFrCpY4zYXi9xXQ@mail.gmail.com> (raw)
In-Reply-To: <20190211165323.9369-5-iforster@suse.com>
On Mon, Feb 11, 2019 at 10:27 PM Ignaz Forster <iforster@suse.com> wrote:
>
> From: Ignaz Forster <iforster@suse.de>
>
> EVM tries to protect these attributes during copy_up, resulting in
> the failure of the copy_up operation.
>
> This patch will skip the attributes (similar to selinux) to allow
> for later recalculation. This, however, introduces another problem:
> As overlayfs does not check the file integrity on copy_up, files with
> an invalid hash will suddenly become valid again after the copy_up
> operation.
>
"overlayfs doesn't check" means the check is to high in vfs and
needs to move to lower vfs layer?
Same as fixes in vfs_create and vfs_tmpfile.
Thanks,
Amir.
next prev parent reply other threads:[~2019-02-12 2:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 16:53 [RFC PATCH 0/5] Fix overlayfs on EVM Ignaz Forster
2019-02-11 16:53 ` [PATCH 1/5] evm: instead of using the overlayfs i_ino, use the real i_ino Ignaz Forster
2019-02-11 16:53 ` [PATCH 2/5] Rename ima_post_create_tmpfile Ignaz Forster
2019-02-11 16:53 ` [PATCH 3/5] Execute IMA post create hook in vfs_create Ignaz Forster
2019-02-11 16:53 ` [PATCH 4/5] Ignore IMA / EVM xattrs during copy_up Ignaz Forster
2019-02-12 2:55 ` Amir Goldstein [this message]
2019-02-11 16:53 ` [PATCH 5/5] Use __vfs_getxattr to get overlayfs xattrs Ignaz Forster
2019-02-12 3:29 ` [RFC PATCH 0/5] Fix overlayfs on EVM Amir Goldstein
2019-02-12 10:55 ` Fabian Vogt
2019-02-12 13:47 ` Amir Goldstein
2019-02-12 22:51 ` Mimi Zohar
2019-02-13 8:05 ` Fabian Vogt
2019-02-13 9:13 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxhrGtPxUVBfxoiGLh_5+qktC_0CC+CaFrCpY4zYXi9xXQ@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=fvogt@suse.com \
--cc=fvogt@suse.de \
--cc=iforster@suse.com \
--cc=iforster@suse.de \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).