linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>,
	linux-integrity <linux-integrity@vger.kernel.org>,
	Eric Snowberg <eric.snowberg@oracle.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	dwmw2@infradead.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, jmorris@namei.org, serge@hallyn.com,
	nayna@linux.ibm.com, erichte@linux.ibm.com, mpe@ellerman.id.au,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH v4] certs: Add EFI_CERT_X509_GUID support for dbx entries
Date: Sat, 30 Jan 2021 01:27:21 +0200	[thread overview]
Message-ID: <YBSZ2bfYsUo2Y28i@kernel.org> (raw)
In-Reply-To: <61a0420790250807837b5a701bb52f3d63ff0c84.camel@linux.ibm.com>

On Wed, Jan 27, 2021 at 09:03:59AM -0500, Mimi Zohar wrote:
> [Cc'ing linux-integrity]
> 
> On Wed, 2021-01-27 at 11:46 +0000, David Howells wrote:
> > Jarkko Sakkinen <jarkko@kernel.org> wrote:
> > 
> > > > I suppose a user space tool could be created. But wouldn’t what is
> > > > currently done in the kernel in this area need to be removed?
> > > 
> > > Right. I don't think this was a great idea in the first place to
> > > do to the kernel but since it exists, I guess the patch does make
> > > sense.
> > 
> > This information needs to be loaded from the UEFI tables before the system
> > starts loading any kernel modules or running any programs (if we do
> > verification of such, which I think IMA can do).
> 
> There needs to a clear distinction between the pre-boot and post-boot
> keys.  UEFI has its own trust model, which should be limited to UEFI. 
> The .platform keyring was upstreamed and limited to verifying the kexec
> kernel image.   Any other usage of the .platform keyring keys is
> abusing its intended purpose.
> 
> The cover letter says,   "Anytime the .platform keyring is used, the
> keys in the .blacklist keyring are referenced, if a matching key is
> found, the key will be rejected."   I don't have a problem with loading
> the UEFI X509 dbx entries as long as its usage is limited to verifying
> the kexec kernel image.
> 
> Mimi

Thanks Mimi, this is a valid argument. I agree.

/Jarkko

      parent reply	other threads:[~2021-01-29 23:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <YAjMm9Gq/FFOzQYG@kernel.org>
     [not found] ` <E090372C-06A3-4991-8FC3-F06A0DA60729@oracle.com>
     [not found]   ` <20200916004927.64276-1-eric.snowberg@oracle.com>
     [not found]     ` <1360578.1607593748@warthog.procyon.org.uk>
     [not found]       ` <2442460.1610463459@warthog.procyon.org.uk>
     [not found]         ` <X/9a8naM8p4tT5sO@linux.intel.com>
     [not found]           ` <A05E3573-B1AF-474B-94A5-779E69E5880A@oracle.com>
     [not found]             ` <YAFdNiYZSWpB9vOw@kernel.org>
     [not found]               ` <CFBF6AEC-2832-44F7-9D7F-F20489498C33@oracle.com>
     [not found]                 ` <YAgTawk3EENF/P6j@kernel.org>
     [not found]                   ` <D9F5E0BD-E2FC-428F-91B3-35D2750493A0@oracle.com>
     [not found]                     ` <3063834.1611747971@warthog.procyon.org.uk>
2021-01-27 14:03                       ` [PATCH v4] certs: Add EFI_CERT_X509_GUID support for dbx entries Mimi Zohar
2021-01-27 15:41                         ` Eric Snowberg
2021-01-28  4:13                           ` Nayna
2021-01-30 10:24                           ` Jarkko Sakkinen
2021-01-29 23:27                         ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBSZ2bfYsUo2Y28i@kernel.org \
    --to=jarkko@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=eric.snowberg@oracle.com \
    --cc=erichte@linux.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).