From: Jarkko Sakkinen <jarkko@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
stable@vger.kernel.org, David Howells <dhowells@redhat.com>,
Sumit Garg <sumit.garg@linaro.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <jejb@linux.ibm.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v5 3/3] KEYS: trusted: Reserve TPM for seal and unseal operations
Date: Tue, 2 Feb 2021 18:29:49 +0200 [thread overview]
Message-ID: <YBl9/V35mwgCWZnl@kernel.org> (raw)
In-Reply-To: <f7c48b191cdb549197a51d7e55c63b13c503e182.camel@linux.ibm.com>
On Sun, Jan 31, 2021 at 07:52:42AM -0500, Mimi Zohar wrote:
> On Sat, 2021-01-30 at 23:28 +0200, Jarkko Sakkinen wrote:
> > On Fri, 2021-01-29 at 08:58 -0500, Mimi Zohar wrote:
> > > On Fri, 2021-01-29 at 01:56 +0200, jarkko@kernel.org wrote:
> > > > From: Jarkko Sakkinen <jarkko@kernel.org>
> > > >
> > > > When TPM 2.0 trusted keys code was moved to the trusted keys subsystem,
> > > > the operations were unwrapped from tpm_try_get_ops() and tpm_put_ops(),
> > > > which are used to take temporarily the ownership of the TPM chip. The
> > > > ownership is only taken inside tpm_send(), but this is not sufficient,
> > > > as in the key load TPM2_CC_LOAD, TPM2_CC_UNSEAL and TPM2_FLUSH_CONTEXT
> > > > need to be done as a one single atom.
> > > >
> > > > Take the TPM chip ownership before sending anything with
> > > > tpm_try_get_ops() and tpm_put_ops(), and use tpm_transmit_cmd() to send
> > > > TPM commands instead of tpm_send(), reverting back to the old behaviour.
> > > >
> > > > Fixes: 2e19e10131a0 ("KEYS: trusted: Move TPM2 trusted keys code")
> > > > Reported-by: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> > > > Cc: stable@vger.kernel.org
> > > > Cc: David Howells <dhowells@redhat.com>
> > > > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > > > Cc: Sumit Garg <sumit.garg@linaro.org>
> > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > >
> > > Tested-by: Mimi Zohar <zohar@linux.ibm.com> (on TPM 1.2 & PTT, discrete
> > > TPM 2.0)
> >
> > Thanks, is it OK to apply the whole series?
>
> Yes. The testing was with the entire patch set, but I didn't
> explicitly test each change. For the other two patches, please add my
> Reviewed-by.
>
> Mimi
Thank you. I will do that.
/Jarkko
prev parent reply other threads:[~2021-02-02 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 23:56 [PATCH v5 0/3] KEYS, trusted: a bunch of bug fixes jarkko
2021-01-28 23:56 ` [PATCH v5 1/3] KEYS: trusted: Fix incorrect handling of tpm_get_random() jarkko
2021-01-31 12:45 ` Mimi Zohar
2021-01-28 23:56 ` [PATCH v5 2/3] KEYS: trusted: Fix migratable=1 failing jarkko
2021-01-28 23:56 ` [PATCH v5 3/3] KEYS: trusted: Reserve TPM for seal and unseal operations jarkko
[not found] ` <CAFA6WYOAbHV=sOxuUdJq91sZbKDMbo6D5KXcSp9ix0PWLpSdaA@mail.gmail.com>
2021-01-30 21:27 ` Jarkko Sakkinen
[not found] ` <6459b955f8cb05dae7d15a233f26ff9c9501b839.camel@linux.ibm.com>
2021-01-30 21:28 ` Jarkko Sakkinen
2021-01-31 12:52 ` Mimi Zohar
2021-02-02 16:29 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBl9/V35mwgCWZnl@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).