From: Jarkko Sakkinen <jarkko@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
Date: Sun, 9 May 2021 23:41:30 +0300 [thread overview]
Message-ID: <YJhI+lIt4devpAoS@kernel.org> (raw)
In-Reply-To: <20210508025444.1977-1-thunder.leizhen@huawei.com>
On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
In the commit message:
1. Instead of writing "a negative error code", write -EFAULT.
2. Some explanation of the choice.
> ---
> drivers/char/tpm/tpm2-cmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
> index eff1f12d981a..c84d23951219 100644
> --- a/drivers/char/tpm/tpm2-cmd.c
> +++ b/drivers/char/tpm/tpm2-cmd.c
> @@ -656,6 +656,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
>
> if (nr_commands !=
> be32_to_cpup((__be32 *)&buf.data[TPM_HEADER_SIZE + 5])) {
> + rc = -EFAULT;
> tpm_buf_destroy(&buf);
> goto out;
> }
> --
> 2.25.1
>
>
>
Other than that looks good.
/Jarkko
next prev parent reply other threads:[~2021-05-09 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 2:54 [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl() Zhen Lei
2021-05-09 20:41 ` Jarkko Sakkinen [this message]
2021-05-12 1:12 ` Leizhen (ThunderTown)
2021-05-12 1:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJhI+lIt4devpAoS@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).