From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: peterhuewe@gmx.de, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v3] char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Thu, 20 May 2021 19:33:58 +0300 [thread overview]
Message-ID: <YKaPdtwAG+IgAZZO@kernel.org> (raw)
In-Reply-To: <1621406999-16816-1-git-send-email-tiantao6@hisilicon.com>
On Wed, May 19, 2021 at 02:49:59PM +0800, Tian Tao wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> Link: https://lore.kernel.org/patchwork/patch/1388765/
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: add the Link.
> v3: put sob last.
> ---
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index f19c227..44dde2f 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -706,14 +706,14 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client,
>
> if (client->irq > 0) {
> rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
> + IRQF_NO_AUTOEN,
> dev->driver->name, chip);
> if (rc < 0) {
> dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
> return rc;
> }
>
> - disable_irq(client->irq);
> priv->irq = client->irq;
> } else {
> dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n",
> --
> 2.7.4
>
>
How does this differ from
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=da2f0c7b46171175ab54da248752b1139c42fee4
?
/Jarkko
next prev parent reply other threads:[~2021-05-20 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 6:49 [PATCH v3] char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-05-20 16:33 ` Jarkko Sakkinen [this message]
2021-05-21 0:52 ` tiantao (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKaPdtwAG+IgAZZO@kernel.org \
--to=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).