From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2F8C433ED for ; Thu, 20 May 2021 16:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7A7A61019 for ; Thu, 20 May 2021 16:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbhETQol (ORCPT ); Thu, 20 May 2021 12:44:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:41746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232565AbhETQol (ORCPT ); Thu, 20 May 2021 12:44:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E3BC60FDC; Thu, 20 May 2021 16:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621528999; bh=z2oOpaIdAemS/NJKyoJhRsl9xYkGM0IF40ygHpxA8lk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cg7kfNPGcuAuehFxxD580CxaAQINBNGsENm52dRZXXzBEkL2s/5sAK1YpDCwzobTs lRpcC3mFe1K1a97wuZyyeG6AxA7jEHH4aKHwTaXWlNWEYb0cjNTyJQYnGeIFdlkPNb GroKvbAU+YxF6k+/HzNtS3oBY/CxrWOCLdCQPdHwz/mDpjP+XlENq5RPQ1ar//zmCS dzrmePBXpkwqZ1ql8ZDI1OyD7VhU3/Az+ztOoiG4hpOgHrLHVysdKZi1C7AoWsu/t7 6AoYzAnSByb8V2Lkc8E5JUtjTGCKuTiE+PtvZnkRBIt77OSZYAbjus/f9uM5OAzUGl 6Y7E58neSqTxw== Date: Thu, 20 May 2021 19:43:17 +0300 From: Jarkko Sakkinen To: Lee Jones Cc: linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Thirupathaiah Annapureddy , linux-integrity@vger.kernel.org Subject: Re: [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Message-ID: References: <20210520121347.3467794-1-lee.jones@linaro.org> <20210520121347.3467794-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520121347.3467794-9-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, May 20, 2021 at 01:13:39PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead > > Cc: Peter Huewe > Cc: Jarkko Sakkinen > Cc: Jason Gunthorpe > Cc: Thirupathaiah Annapureddy > Cc: linux-integrity@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_ftpm_tee.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c > index 2ccdf8ac69948..2d9c0ecd43f0a 100644 > --- a/drivers/char/tpm/tpm_ftpm_tee.c > +++ b/drivers/char/tpm/tpm_ftpm_tee.c > @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data) > > /** > * ftpm_tee_probe() - initialize the fTPM > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * On success, 0. On failure, -errno. > @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev) > > /** > * ftpm_tee_remove() - remove the TPM device > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * 0 always. > @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev) > } > > /** > - * ftpm_tee_shutdown() - shutdown the TPM device > + * ftpm_plat_tee_shutdown() - shutdown the TPM device > * @pdev: the platform_device description. > */ > static void ftpm_plat_tee_shutdown(struct platform_device *pdev) > -- > 2.31.1 > >