From: Petr Vorel <pvorel@suse.cz>
To: Alex Henrie <alexh@vpitech.com>
Cc: linux-integrity@vger.kernel.org, ltp@lists.linux.it,
zohar@linux.ibm.com, alexhenrie24@gmail.com
Subject: Re: [PATCH ltp v4 3/3] IMA: Add tests for uid, gid, fowner, and fgroup options
Date: Tue, 21 Sep 2021 09:45:59 +0200 [thread overview]
Message-ID: <YUmNt06CD97u0Drs@pevik> (raw)
In-Reply-To: <20210921004140.15041-3-alexh@vpitech.com>
Hi Alex,
...
> +++ b/testcases/kernel/security/integrity/ima/tests/ima_conditionals.sh
> @@ -0,0 +1,57 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) 2021 VPI Technology
> +# Author: Alex Henrie <alexh@vpitech.com>
> +#
> +# Verify that conditional rules work.
> +
> +TST_NEEDS_CMDS="awk chgrp chown cut sg sudo"
awk, cut are not used. Or is that a dependency from some helpers in
ima_setup.sh? (these should check the dependency themselves via tst_require_cmds).
The rest LGTM, I just need to retest it.
Kind regards,
Petr
prev parent reply other threads:[~2021-09-21 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 0:41 [PATCH ltp v4 1/3] IMA: Move check_policy_writable to ima_setup.sh and rename it Alex Henrie
2021-09-21 0:41 ` [PATCH ltp v4 2/3] IMA: Move ima_check to ima_setup.sh Alex Henrie
2021-09-21 0:41 ` [PATCH ltp v4 3/3] IMA: Add tests for uid, gid, fowner, and fgroup options Alex Henrie
2021-09-21 7:45 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUmNt06CD97u0Drs@pevik \
--to=pvorel@suse.cz \
--cc=alexh@vpitech.com \
--cc=alexhenrie24@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).