From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tpm: st33zp24: drop support for platform data
Date: Fri, 30 Sep 2022 21:11:09 -0700 [thread overview]
Message-ID: <Yze93XOi2+IBVOI+@google.com> (raw)
In-Reply-To: <YzdT6kkPXSXZ9hdB@kernel.org>
On Fri, Sep 30, 2022 at 11:39:06PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 25, 2022 at 10:39:56PM -0700, Dmitry Torokhov wrote:
> > There are no users of st33zp24_platform_data in mainline, and new boards
> > should be using device tree or ACPI to describe resources, so let's drop
> > support for platform data from the driver.
>
> Nit: drop instead of let's drop (needs also different sentence structure
> obviously).
OK.
>
> Also, please leave predictions out, or back them up with data. It's good
> enough reason to remove code, if it is not used for anything. I really
> don't care about "should" part. It is is out-of-scope for a kernel
> patch.
This is not a prediction, but a statement. The idea I was trying to
express is that platform data is needed for legacy boards, those that
predate device tree and/or ACPI support. Therefore there will be no
new users of it appearing in the kernel, as we will not accept a new
board/architecture it using wither ACPI or DT.
Thanks.
--
Dmitry
prev parent reply other threads:[~2022-10-01 4:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 5:39 [PATCH 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
2022-09-26 5:39 ` [PATCH 2/3] tpm: st33zp24: switch to using gpiod API Dmitry Torokhov
2022-09-30 20:43 ` Jarkko Sakkinen
2022-09-26 5:39 ` [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe Dmitry Torokhov
2022-09-30 20:44 ` Jarkko Sakkinen
2022-10-01 4:13 ` Dmitry Torokhov
2022-09-30 20:39 ` [PATCH 1/3] tpm: st33zp24: drop support for platform data Jarkko Sakkinen
2022-10-01 4:11 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yze93XOi2+IBVOI+@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).