linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tpm: st33zp24: drop support for platform data
Date: Wed, 5 Oct 2022 01:10:06 +0300	[thread overview]
Message-ID: <YzyvPq/VYiuvz6LS@kernel.org> (raw)
In-Reply-To: <20221001055142.3196483-1-dmitry.torokhov@gmail.com>

On Fri, Sep 30, 2022 at 10:51:40PM -0700, Dmitry Torokhov wrote:
> Drop support for platform data from the driver because there are no
> users of st33zp24_platform_data structure in the mainline kernel.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> -		.name = TPM_ST33_SPI,
> +		.name = "st33zp24-spi",
>  		.pm = &st33zp24_spi_ops,
>  		.of_match_table = of_match_ptr(of_st33zp24_spi_match),
>  		.acpi_match_table = ACPI_PTR(st33zp24_spi_acpi_match),
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.h b/drivers/char/tpm/st33zp24/st33zp24.h
> index b387a476c555..6a26dbc3206b 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.h
> +++ b/drivers/char/tpm/st33zp24/st33zp24.h
> @@ -7,6 +7,9 @@
>  #ifndef __LOCAL_ST33ZP24_H__
>  #define __LOCAL_ST33ZP24_H__
>  
> +#define TPM_ST33_I2C		"st33zp24-i2c"
> +#define TPM_ST33_SPI		"st33zp24-spi"
> +
>  #define TPM_WRITE_DIRECTION	0x80
>  #define ST33ZP24_BUFSIZE	2048

Sorry I missed this. Why don't you use TPM_ST33_SPI constant above
since you are anyway re-defining it?

BR, Jarkko

      parent reply	other threads:[~2022-10-04 22:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  5:51 [PATCH v2 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
2022-10-01  5:51 ` [PATCH v2 2/3] tpm: st33zp24: switch to using gpiod API Dmitry Torokhov
2022-10-01  5:51 ` [PATCH v2 3/3] tpm: st33zp24: remove pointless checks on probe Dmitry Torokhov
2022-10-04 22:04 ` [PATCH v2 1/3] tpm: st33zp24: drop support for platform data Jarkko Sakkinen
2022-10-04 22:10 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzyvPq/VYiuvz6LS@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).