Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
	joe@perches.com, skhan@linuxfoundation.org,
	linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima
Date: Wed, 12 Feb 2020 14:25:19 -0800
Message-ID: <a3cbb918-887a-4534-144b-7a392d766bdb@linux.microsoft.com> (raw)
In-Reply-To: <1581518950.8515.51.camel@linux.ibm.com>


On 2020-02-12 6:49 a.m., Mimi Zohar wrote:
> On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote:
>> Log statements from ima_mok.c, ima_asymmetric_keys.c, and
>> ima_queue_keys.c are prefixed with the respective file names
>> and not with the string "ima".
> 
> Before listing the specific filenames, the patch description should
> provide a generic explanation of the problem.  For example, the kernel
> Makefile "obj-$CONFIG_XXXX" specifies object files which may be built
> as loadable kernel modules[1].
> 
Thanks Mimi. I will update the patch description in the next iteration.


> Mimi
> 
> [1] Refer to Documentation/kbuild/makefiles.rst
> 
>>
>> This change fixes the log statement prefix to be consistent with the rest
>> of the IMA files.
>>
>> Signed-off-by: Tushar Sugandhi <tusharsu@linux.microsoft.com>
>> Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
>> ---
>>   security/integrity/ima/Makefile | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/security/integrity/ima/Makefile b/security/integrity/ima/Makefile
>> index 064a256f8725..67dabca670e2 100644
>> --- a/security/integrity/ima/Makefile
>> +++ b/security/integrity/ima/Makefile
>> @@ -11,6 +11,6 @@ ima-y := ima_fs.o ima_queue.o ima_init.o ima_main.o ima_crypto.o ima_api.o \
>>   ima-$(CONFIG_IMA_APPRAISE) += ima_appraise.o
>>   ima-$(CONFIG_IMA_APPRAISE_MODSIG) += ima_modsig.o
>>   ima-$(CONFIG_HAVE_IMA_KEXEC) += ima_kexec.o
>> -obj-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
>> -obj-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
>> -obj-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o
>> +ima-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
>> +ima-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
>> +ima-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 23:14 [PATCH v3 0/3] IMA: improve log messages in IMA Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-12 14:49   ` Mimi Zohar
2020-02-12 22:25     ` Tushar Sugandhi [this message]
2020-02-11 23:14 ` [PATCH v3 2/3] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-12 14:47   ` Mimi Zohar
2020-02-12 22:30     ` Tushar Sugandhi
2020-02-13  0:21       ` Mimi Zohar
2020-02-13 21:01         ` Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 3/3] IMA: Add module name and base name prefix to log Tushar Sugandhi
2020-02-12 14:29   ` Mimi Zohar
2020-02-12 15:26     ` James Bottomley
2020-02-12 15:47       ` Joe Perches
2020-02-12 22:52       ` Shuah Khan
2020-02-13  0:38         ` Mimi Zohar
2020-02-13  0:56           ` Tushar Sugandhi
2020-02-12 15:23 ` [PATCH v3 0/3] IMA: improve log messages in IMA Mimi Zohar
2020-02-12 22:22   ` Tushar Sugandhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3cbb918-887a-4534-144b-7a392d766bdb@linux.microsoft.com \
    --to=tusharsu@linux.microsoft.com \
    --cc=joe@perches.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=sashal@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git