From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Ard Biesheuvel" <ardb@kernel.org>, "Loïc Yhuel" <loic.yhuel@gmail.com>
Cc: linux-integrity@vger.kernel.org,
Matthew Garrett <matthewgarrett@google.com>,
javierm@redhat.com
Subject: Re: [PATCH] tpm: check event log version before reading final events
Date: Thu, 14 May 2020 13:51:53 +0300 [thread overview]
Message-ID: <aa633c59f845817f7ada8089f29638bdfdb016a3.camel@linux.intel.com> (raw)
In-Reply-To: <CAMj1kXFPt4eSDCC61paWhyfOaEeWUgUQSnczwZJ7Eny8t7ow5g@mail.gmail.com>
On Tue, 2020-05-12 at 14:30 +0200, Ard Biesheuvel wrote:
> On Tue, 12 May 2020 at 13:40, Loïc Yhuel <loic.yhuel@gmail.com> wrote:
> > Le mar. 12 mai 2020 à 08:45, Ard Biesheuvel <ardb@kernel.org> a écrit :
> > > So what functionality do we lose here? Can we still make meaningful
> > > use of the event log without the final log? I thought one was
> > > incomplete without the other?
> > The char driver (drivers/char/tpm/eventlog/efi.c), already ignores
> > efi.tpm_final_log
> > if the event log version isn't EFI_TCG2_EVENT_LOG_FORMAT_TCG_2.
> > So there currently no code making use of the final log contents on
> > those machines,
> > besides the two cases I patched which only try to determine its size.
> >
>
> Ah ok, thanks for clarifying. If we never consume it anyway, then I
> agree this is the correct fix.
I think issuing a warning would not be a bad idea given the incompleteness
of the even log.
/Jarkko
next prev parent reply other threads:[~2020-05-14 10:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 4:01 [PATCH] tpm: check event log version before reading final events Loïc Yhuel
2020-05-12 6:44 ` Ard Biesheuvel
2020-05-12 11:40 ` Loïc Yhuel
2020-05-12 12:30 ` Ard Biesheuvel
2020-05-14 10:51 ` Jarkko Sakkinen [this message]
2020-05-14 1:09 ` Jarkko Sakkinen
2020-05-14 8:10 ` Ard Biesheuvel
2020-05-14 23:44 ` Jarkko Sakkinen
2020-05-12 17:45 ` Javier Martinez Canillas
2020-05-12 18:45 ` Jerry Snitselaar
2020-05-12 20:08 ` Matthew Garrett
2020-05-14 10:53 ` Jarkko Sakkinen
2020-05-14 11:28 ` Loïc Yhuel
2020-05-14 11:31 ` Ard Biesheuvel
2020-05-15 0:03 ` Jarkko Sakkinen
2020-05-14 11:33 ` Javier Martinez Canillas
2020-05-14 12:28 ` Ard Biesheuvel
2020-05-14 12:56 ` Javier Martinez Canillas
2020-05-14 13:04 ` Ard Biesheuvel
2020-05-14 13:51 ` Javier Martinez Canillas
2020-05-14 18:06 ` Matthew Garrett
2020-05-15 15:55 ` Loïc Yhuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa633c59f845817f7ada8089f29638bdfdb016a3.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ardb@kernel.org \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=loic.yhuel@gmail.com \
--cc=matthewgarrett@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).