From: Stefan Berger <stefanb@linux.ibm.com> To: Jarkko Sakkinen <jarkko@kernel.org>, Stefan Berger <stefanb@linux.vnet.ibm.com> Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Nayna Jain <nayna@linux.ibm.com>, George Wilson <gcwilson@linux.ibm.com>, Nageswara R Sastry <rnsastry@linux.ibm.com> Subject: Re: [PATCH] tpm: ibmvtpm: Avoid error message when process gets signal while waiting Date: Mon, 26 Jul 2021 23:00:51 -0400 [thread overview] Message-ID: <ad4011fb-fc1f-4019-9856-7d171db3255c@linux.ibm.com> (raw) In-Reply-To: <20210727024225.swqy5ypcytsngpd6@kernel.org> On 7/26/21 10:42 PM, Jarkko Sakkinen wrote: > On Mon, Jul 12, 2021 at 12:25:05PM -0400, Stefan Berger wrote: >> From: Stefan Berger <stefanb@linux.ibm.com> >> >> When rngd is run as root then lots of these types of message will appear >> in the kernel log if the TPM has been configure to provide random bytes: >> >> [ 7406.275163] tpm tpm0: tpm_transmit: tpm_recv: error -4 >> >> The issue is caused by the following call that is interrupted while >> waiting for the TPM's response. >> >> sig = wait_event_interruptible(ibmvtpm->wq, >> !ibmvtpm->tpm_processing_cmd); >> >> The solution is to use wait_event() instead. > Why? So it becomes uninterruptible and these error messages go away. Stefan > > /Jarkko
next prev parent reply other threads:[~2021-07-27 3:00 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-12 16:25 Stefan Berger 2021-07-13 5:03 ` Nageswara Sastry 2021-07-27 2:42 ` Jarkko Sakkinen 2021-07-27 3:00 ` Stefan Berger [this message] 2021-07-28 21:50 ` Jarkko Sakkinen 2021-07-29 13:39 ` Stefan Berger 2021-07-30 0:57 ` Jarkko Sakkinen 2021-07-30 11:45 ` Stefan Berger 2021-07-29 16:19 Stefan Berger 2021-07-30 4:15 ` Nageswara Sastry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ad4011fb-fc1f-4019-9856-7d171db3255c@linux.ibm.com \ --to=stefanb@linux.ibm.com \ --cc=gcwilson@linux.ibm.com \ --cc=jarkko@kernel.org \ --cc=jgg@ziepe.ca \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=nayna@linux.ibm.com \ --cc=peterhuewe@gmx.de \ --cc=rnsastry@linux.ibm.com \ --cc=stefanb@linux.vnet.ibm.com \ --subject='Re: [PATCH] tpm: ibmvtpm: Avoid error message when process gets signal while waiting' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).