Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] MAINTAINERS: adjust to trusted keys subsystem creation
@ 2020-03-04 21:12 Lukas Bulwahn
  2020-03-05  4:43 ` Sumit Garg
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2020-03-04 21:12 UTC (permalink / raw)
  To: Sumit Garg, James Bottomley, Jarkko Sakkinen, Mimi Zohar
  Cc: linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

  warning: no file matches F: security/keys/trusted.c
  warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
files in security/keys/ are identified as part of KEYS-TRUSTED.

Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Changes to v1:
- use a global pattern for matching the whole security/keys/ directory.
Sumit, please ack.
James or Jarkko, please pick this patch v2.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5c755e03ddee..7f11ac752b91 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9276,8 +9276,8 @@ L:	keyrings@vger.kernel.org
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
-F:	security/keys/trusted.c
-F:	include/keys/trusted.h
+F:	include/keys/trusted_tpm.h
+F:	security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:	David Howells <dhowells@redhat.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-04 21:12 [PATCH v2] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
@ 2020-03-05  4:43 ` Sumit Garg
  2020-03-05 20:32   ` Lukas Bulwahn
  0 siblings, 1 reply; 3+ messages in thread
From: Sumit Garg @ 2020-03-05  4:43 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: James Bottomley, Jarkko Sakkinen, Mimi Zohar, linux-integrity,
	open list:ASYMMETRIC KEYS, Sebastian Duda, Joe Perches,
	kernel-janitors, Linux Kernel Mailing List

On Thu, 5 Mar 2020 at 02:43, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
>   warning: no file matches F: security/keys/trusted.c
>   warning: no file matches F: include/keys/trusted.h
>
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> files in security/keys/ are identified as part of KEYS-TRUSTED.
>

I guess you meant here security/keys/trusted-keys/ instead of security/keys/.

-Sumit

> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Changes to v1:
> - use a global pattern for matching the whole security/keys/ directory.
> Sumit, please ack.
> James or Jarkko, please pick this patch v2.
>
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c755e03ddee..7f11ac752b91 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9276,8 +9276,8 @@ L:        keyrings@vger.kernel.org
>  S:     Supported
>  F:     Documentation/security/keys/trusted-encrypted.rst
>  F:     include/keys/trusted-type.h
> -F:     security/keys/trusted.c
> -F:     include/keys/trusted.h
> +F:     include/keys/trusted_tpm.h
> +F:     security/keys/trusted-keys/
>
>  KEYS/KEYRINGS
>  M:     David Howells <dhowells@redhat.com>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05  4:43 ` Sumit Garg
@ 2020-03-05 20:32   ` Lukas Bulwahn
  0 siblings, 0 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2020-03-05 20:32 UTC (permalink / raw)
  To: Sumit Garg
  Cc: Lukas Bulwahn, James Bottomley, Jarkko Sakkinen, Mimi Zohar,
	linux-integrity, open list:ASYMMETRIC KEYS, Sebastian Duda,
	Joe Perches, kernel-janitors, Linux Kernel Mailing List



On Thu, 5 Mar 2020, Sumit Garg wrote:

> On Thu, 5 Mar 2020 at 02:43, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> > renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> > to trusted-keys/trusted_tpm1.c in security/keys/.
> >
> > Since then, ./scripts/get_maintainer.pl --self-test complains:
> >
> >   warning: no file matches F: security/keys/trusted.c
> >   warning: no file matches F: include/keys/trusted.h
> >
> > Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> > files in security/keys/ are identified as part of KEYS-TRUSTED.
> >
> 
> I guess you meant here security/keys/trusted-keys/ instead of security/keys/.
>

Yes, that is what I meant. I rushed the patch v2 last night.

Here is hopefully now a PATCH v3 you can ack:

https://lore.kernel.org/linux-integrity/20200305203013.6189-1-lukas.bulwahn@gmail.com/T/#u

Lukas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 21:12 [PATCH v2] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
2020-03-05  4:43 ` Sumit Garg
2020-03-05 20:32   ` Lukas Bulwahn

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git