From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-integrity@vger.kernel.org,
Jeremy Boone <jeremy.boone@nccgroup.trust>
Subject: Re: [PATCH] tpm: st33zp24: Convert to use GPIO descriptors
Date: Thu, 05 Mar 2020 13:43:29 +0200 [thread overview]
Message-ID: <b761fab86e36ca2167b6d15474315ca2d75cc8d1.camel@linux.intel.com> (raw)
In-Reply-To: <20200304221700.22958-1-linus.walleij@linaro.org>
On Wed, 2020-03-04 at 23:17 +0100, Linus Walleij wrote:
> The ST33ZP24 is using the old deprecated GPIO API.
> It also goes to some measures to convert from the
> new to the old API in the ACPI probe path of both
> the I2C and SPI interfaces for the module.
>
> Change the driver and subdrivers to use struct
> gpio_desc * all the way and pass this around in
> platform data and in probe and all associated
> functions.
>
> Cc: Jeremy Boone <jeremy.boone@nccgroup.trust>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, look great.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
[with the assumption that it passes sparse and checkpatch.pl]
Any chance to get like maybe even one tested-by for this? The change
is so straightforward and obvious that I'll pick it up anyway but
would feel better to have it tested by another peer.
/Jarkko
prev parent reply other threads:[~2020-03-05 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 22:17 [PATCH] tpm: st33zp24: Convert to use GPIO descriptors Linus Walleij
2020-03-05 11:43 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b761fab86e36ca2167b6d15474315ca2d75cc8d1.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jeremy.boone@nccgroup.trust \
--cc=jgg@ziepe.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).