From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Stefan Berger <stefanb@linux.ibm.com>,
peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc: stefanb@linux.vnet.ibm.com,
James.Bottomley@hansenpartnership.com, keescook@chromium.org,
jsnitsel@redhat.com, ml.linux@elloe.vision,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] tpm: Fix test for interrupts
Date: Thu, 29 Apr 2021 00:13:23 +0200 [thread overview]
Message-ID: <b9ccf9df-2b0a-5bff-d38f-bad05cad9896@gmx.de> (raw)
In-Reply-To: <e0b34384-d286-2251-bc43-0ee3083672b3@linux.ibm.com>
Hi,
On 26.04.21 at 16:49, Stefan Berger wrote:
>> diff --git a/include/linux/tpm.h b/include/linux/tpm.h
>> index 55debe6..e9882acf 100644
>> --- a/include/linux/tpm.h
>> +++ b/include/linux/tpm.h
>> @@ -126,7 +126,7 @@ struct tpm_chip {
>> struct tpm_chip_seqops bin_log_seqops;
>> struct tpm_chip_seqops ascii_log_seqops;
>> - unsigned int flags;
>> + unsigned long flags;
>
>
> This doesn't seem to be necessary.
>
The bitop makros require an unsigned long, leaving it as unsigned int results in
a compiler error:
error: passing argument 2 of ‘test_bit’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> The rest looks good to me. I remember that last time I had tried to activate it some laptop didn't cooperate and we ended up reverting some code, but maybe your changes fixed all of that now. Though you may want to 'prepare for unforseen consequences' :-).
>
You may be right with your concerns and I will try to find some more hardware to test the patches.
Thanks for the review(s).
Regards,
Lino
next prev parent reply other threads:[~2021-04-28 22:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 23:47 [PATCH v2 0/4] Fixes for TPM interrupt handling Lino Sanfilippo
2021-04-25 23:47 ` [PATCH v2 1/4] tpm: Use a threaded interrupt handler Lino Sanfilippo
2021-04-26 14:37 ` Stefan Berger
2021-04-27 23:53 ` Jarkko Sakkinen
2021-04-28 22:37 ` Lino Sanfilippo
2021-04-29 6:58 ` Jarkko Sakkinen
2021-05-01 9:01 ` Lino Sanfilippo
2021-04-25 23:47 ` [PATCH v2 2/4] tpm: Simplify locality handling Lino Sanfilippo
2021-04-27 23:49 ` Jarkko Sakkinen
2021-04-28 7:13 ` Peter.Huewe
2021-04-28 22:44 ` Lino Sanfilippo
2021-04-25 23:47 ` [PATCH v2 3/4] tpm: Fix test for interrupts Lino Sanfilippo
2021-04-26 14:49 ` Stefan Berger
2021-04-28 22:13 ` Lino Sanfilippo [this message]
2021-04-25 23:47 ` [PATCH v2 4/4] tpm: Only enable supported irqs Lino Sanfilippo
2021-04-26 5:08 ` kernel test robot
2021-04-26 14:23 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ccf9df-2b0a-5bff-d38f-bad05cad9896@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ml.linux@elloe.vision \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).