From: Milan Broz <gmazyland@gmail.com>
To: Jaskaran Singh Khurana <jaskarankhurana@linux.microsoft.com>
Cc: ebiggers@google.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org, agk@redhat.com,
snitzer@redhat.com, dm-devel@redhat.com, jmorris@namei.org,
Scott Shell <SCOTTSH@microsoft.com>,
Nazmus Sakib <mdsakib@microsoft.com>,
mpatocka@redhat.com
Subject: Re: [RFC PATCH v6 0/1] Add dm verity root hash pkcs7 sig validation.
Date: Wed, 17 Jul 2019 15:08:13 +0200 [thread overview]
Message-ID: <bdcd7d7c-92fc-11af-7924-9bd0e184b427@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.1907161035490.121213@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.inter>
Hi,
On 16/07/2019 20:08, Jaskaran Singh Khurana wrote:
>>> Could you please provide feedback on this v6 version.
>>
>> Hi,
>>
>> I am ok with the v6 patch; I think Mike will return to it in 5.4 reviews.
>>
>
> Thanks for the help and also for reviewing this patch. Could you please
> add Reviewed-by/Tested-by tag to the patch.
ok, you can add
Tested-and-Reviewed-by: Milan Broz <gmazyland@gmail.com>
or just use the version on my git, I already updated few lines because
of recent kernel changes, mainly the revert of keyring changes, tested patch is here
https://git.kernel.org/pub/scm/linux/kernel/git/mbroz/linux.git/commit/?h=dm-cryptsetup&id=266f7c9c74b23e4cb2e67ceb813dd707061c1641
...
> The steps and workflow is correct. I will send the cryptsetup changes for
> review.
ok, I'll probably try to use our existing userspace libcryptsetup API to avoid introducing new calls,
but that is not important for now - the kernel bits must be in the mainline kernel first.
Thanks,
Milan
prev parent reply other threads:[~2019-07-17 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 18:19 [RFC PATCH v6 0/1] Add dm verity root hash pkcs7 sig validation Jaskaran Khurana
2019-07-01 18:19 ` [RFC PATCH v6 1/1] " Jaskaran Khurana
[not found] ` <MN2PR21MB12008A962D4DD8662B3614508AF20@MN2PR21MB1200.namprd21.prod.outlook.com>
2019-07-12 17:33 ` [RFC PATCH v6 0/1] " Jaskaran Singh Khurana
2019-07-16 12:59 ` Milan Broz
2019-07-16 18:08 ` Jaskaran Singh Khurana
2019-07-17 13:08 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdcd7d7c-92fc-11af-7924-9bd0e184b427@gmail.com \
--to=gmazyland@gmail.com \
--cc=SCOTTSH@microsoft.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=jaskarankhurana@linux.microsoft.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mdsakib@microsoft.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).