From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Doug Anderson <dianders@chromium.org>, Sasha Levin <sashal@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"# 4.0+" <stable@vger.kernel.org>,
Vadim Sukhomlinov <sukhomlinov@google.com>,
linux-integrity@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Date: Sat, 07 Sep 2019 19:55:53 +0300 [thread overview]
Message-ID: <c41c38aa288d92502edf72f8c8f34f58c251db00.camel@linux.intel.com> (raw)
In-Reply-To: <CAD=FV=W0YodeoOCiCv9zmv+-gswuU8U_XgrBnesE=wynTbDBiA@mail.gmail.com>
On Tue, 2019-09-03 at 09:39 -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin <sashal@kernel.org> wrote:
> > From: Vadim Sukhomlinov <sukhomlinov@google.com>
> >
> > [ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ]
> >
> > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
> > future TPM operations. TPM 1.2 behavior was different, future TPM
> > operations weren't disabled, causing rare issues. This patch ensures
> > that future TPM operations are disabled.
> >
> > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Vadim Sukhomlinov <sukhomlinov@google.com>
> > [dianders: resolved merge conflicts with mainline]
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> > drivers/char/tpm/tpm-chip.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Jarkko: did you deal with the issues that came up in response to my
> post? Are you happy with this going into 4.19 stable at this point?
> I notice this has your Signed-off-by so maybe?
No I have not dealt with the issues yet. The last thing I've said about
this is:
https://lore.kernel.org/stable/20190805210501.vjtmwgxjg334vtnc@linux.intel.com/
I was actually going to look into this during the plane trip to Lissabon
tomorrow morning. I have in mind that this needs to be backported first:
db4d8cb9c9f2 ("tpm: use tpm_try_get_ops() in tpm-sysfs.c.")
/Jarkko
prev parent reply other threads:[~2019-09-07 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190903162519.7136-1-sashal@kernel.org>
2019-09-03 16:23 ` [PATCH AUTOSEL 4.19 062/167] tpm: Fix some name collisions with drivers/char/tpm.h Sasha Levin
2019-09-03 16:24 ` [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Sasha Levin
2019-09-03 16:39 ` Doug Anderson
2019-09-03 16:53 ` Jerry Snitselaar
2019-09-03 19:43 ` Sasha Levin
2019-09-07 18:55 ` Jarkko Sakkinen
2019-09-07 22:04 ` Sasha Levin
2019-09-09 16:28 ` Jarkko Sakkinen
2019-09-11 7:56 ` Sasha Levin
2019-09-15 15:19 ` Jarkko Sakkinen
2019-09-07 16:55 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c41c38aa288d92502edf72f8c8f34f58c251db00.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dianders@chromium.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sukhomlinov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).