From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30FECA9EBB for ; Thu, 24 Oct 2019 14:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98FC4205F4 for ; Thu, 24 Oct 2019 14:47:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cU4i5Pe5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409484AbfJXOr3 (ORCPT ); Thu, 24 Oct 2019 10:47:29 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:37151 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731880AbfJXOr3 (ORCPT ); Thu, 24 Oct 2019 10:47:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571928445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXiCj2zY2Ut1vFe48odKp1CcDmx3S+KKbQVXOdnSjyw=; b=cU4i5Pe5QeRK869U7FqI03d/b7/YP9sLNF8Re4qjqJHZBPvnHegAUeqqArp5uLIURYdMZK zdN3CfOkanB2mLg4woGZe04zaP+jMN8DoM84SIxI7E+nFPQqxASDz/esr33fJXh5BNnQBD yHT+4skGUVKOsCoiVjzH1a40ylm6Nmk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-0JfRiF7rPmO6D8hp4wRK3Q-1; Thu, 24 Oct 2019 10:47:09 -0400 Received: by mail-wm1-f70.google.com with SMTP id z23so1181246wml.0 for ; Thu, 24 Oct 2019 07:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T/Xlag7Vv94i/fFZydhE/2Ef/Fmjkx03xUXJUBM16NE=; b=ZuY4CXHcDx+vyNbP0ZJsCsmSCMOwXe1HCdOtJLFtGti+WK4AtH8Q9Vfh081r9HFeVO oL3ALOu6FbFocf2JgYa5FxKlzvH8bx1bPmSnSTDfTeMjg85SAY88nntKUEp8fCD5tbQZ oNvo13Ic0RCqdF6mkLbCqyF17LyV9i6YgKPR/Cj3OEzBEHyNM4BnZZX/S1pLE1OfCJJx qkJZFz+2WnObqI1mmXFAsQYiYlZI7IdSe9yJpdlUpjfMwsr/V3XfHkqxwL8PyLOB5+Yl HtWGQmFafyVPhbTAbZZUiu405KXYztr0xDy1GSYRCac9u3lQ/DW34o8bhGLMUuOvQT+1 DdXQ== X-Gm-Message-State: APjAAAWIgLEMTFD+nyCJrKr57k9FXRqaKAbZSvT5fAax3l5bz3wZPiil j2pmG43x2JdZwO+NDFHihrlzzOTSGxwWojT2Onrt+AfxDuR2PblPcyMT6Xz9MInErqwjfW8cFoc 3jfo0qe55yKjHgtoeUVVDM8Hhuh9h X-Received: by 2002:adf:bd8f:: with SMTP id l15mr4084416wrh.362.1571927246918; Thu, 24 Oct 2019 07:27:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHFHFBiqf2jd4RSI7FQ83LyEV3UvhtzKxFIwh4b5Evb3qiH8AY4i0BFMxyaOtnXcmlN/ePXg== X-Received: by 2002:adf:bd8f:: with SMTP id l15mr4084393wrh.362.1571927246663; Thu, 24 Oct 2019 07:27:26 -0700 (PDT) Received: from shalem.localdomain (2001-1c00-0c14-2800-ec23-a060-24d5-2453.cable.dynamic.v6.ziggo.nl. [2001:1c00:c14:2800:ec23:a060:24d5:2453]) by smtp.gmail.com with ESMTPSA id w18sm7921842wrl.75.2019.10.24.07.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2019 07:27:25 -0700 (PDT) Subject: Re: [PATCH] tpm: Switch to platform_get_irq_optional() To: Jarkko Sakkinen Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, stable@vger.kernel.org References: <20191019094528.27850-1-hdegoede@redhat.com> <20191021154942.GB4525@linux.intel.com> <80409d36-53fa-d159-d864-51b8495dc306@redhat.com> <20191023113733.GB21973@linux.intel.com> <20191024142519.GA3881@linux.intel.com> From: Hans de Goede Message-ID: Date: Thu, 24 Oct 2019 16:27:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191024142519.GA3881@linux.intel.com> Content-Language: en-US X-MC-Unique: 0JfRiF7rPmO6D8hp4wRK3Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi, On 24-10-2019 16:25, Jarkko Sakkinen wrote: > On Wed, Oct 23, 2019 at 04:32:57PM +0200, Hans de Goede wrote: >> Hi, >> >> On 23-10-2019 13:37, Jarkko Sakkinen wrote: >>> On Mon, Oct 21, 2019 at 05:56:56PM +0200, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 21-10-2019 17:49, Jarkko Sakkinen wrote: >>>>> On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote: >>>>>> Since commit 7723f4c5ecdb ("driver core: platform: Add an error mess= age to >>>>>> platform_get_irq*()"), platform_get_irq() will call dev_err() on an = error, >>>>>> as the IRQ usage in the tpm_tis driver is optional, this is undesira= ble. >>>>>> >>>>>> Specifically this leads to this new false-positive error being logge= d: >>>>>> [ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found >>>>>> >>>>>> This commit switches to platform_get_irq_optional(), which does not = log >>>>>> an error, fixing this. >>>>>> >>>>>> Cc: # 5.4.x >>>>> >>>>> Incorrect format (should be wo '<' and '>'). >>>> >>>> According to: >>>> >>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.htm= l >>>> >>>> the '<' and '>' should be added when adding a # >>> >>> OK, right so it was. This first patch that I'm reviewing with such >>> commit. >>> >>>>> Also, not sure why this should be backported to stable kernel anyway. >>>> >>>> Because false-positive error messages are bad and cause users to >>>> file false-positive bug-reports. >>> >>> Neither categorizes into a regression albeit being unfortunate >>> glitches. >> >> The stable series also does other small fixes, such as adding new >> pci/usb-ids, etc. This clearly falls within this. IMHO ideally this >> should go to a 5.4-rc# making the whole discussion moot, but since >> I was afraid it would not make 5.4, I added the Cc: stable. >=20 > I get adding PCI/USB id as it extends the hardware support for the > stable kernel without risking its stability. This patch is factors > less useful. It also has about 0% chance of causing regressions and it does help to avoid false--positive bug reports. TBH I'm quite surprised we are even having this discussion... Regards, Hans