From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org
Cc: aik@ozlabs.ru, david@gibson.dropbear.id.au,
linux-kernel@vger.kernel.org, nayna@linux.vnet.ibm.com,
gcwilson@linux.ibm.com, jgg@ziepe.ca,
Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v6 2/3] tpm: ibmvtpm: Wait for buffer to be set before proceeding
Date: Thu, 05 Mar 2020 13:21:03 +0200 [thread overview]
Message-ID: <cb90bbef11d054c95e4f4633a350674f3c4fe0c5.camel@linux.intel.com> (raw)
In-Reply-To: <20200304132243.179402-3-stefanb@linux.vnet.ibm.com>
On Wed, 2020-03-04 at 08:22 -0500, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
>
> Synchronize with the results from the CRQs before continuing with
> the initialization. This avoids trying to send TPM commands while
> the rtce buffer has not been allocated, yet.
>
> This patch fixes an existing race condition that may occurr if the
> hypervisor does not quickly respond to the VTPM_GET_RTCE_BUFFER_SIZE
> request sent during initialization and therefore the ibmvtpm->rtce_buf
> has not been allocated at the time the first TPM command is sent.
>
> Fixes: 132f76294744 ("Add new device driver to support IBM vTPM")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2020-03-05 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 13:22 [PATCH v6 0/3] Enable vTPM 2.0 for the IBM vTPM driver Stefan Berger
2020-03-04 13:22 ` [PATCH v6 1/3] tpm: of: Handle IBM,vtpm20 case when getting log parameters Stefan Berger
2020-03-10 22:56 ` kbuild test robot
2020-03-11 12:58 ` Stefan Berger
2020-03-04 13:22 ` [PATCH v6 2/3] tpm: ibmvtpm: Wait for buffer to be set before proceeding Stefan Berger
2020-03-05 11:21 ` Jarkko Sakkinen [this message]
2020-03-04 13:22 ` [PATCH v6 3/3] tpm: ibmvtpm: Add support for TPM2 Stefan Berger
2020-03-05 11:21 ` Jarkko Sakkinen
2020-03-05 13:58 ` Stefan Berger
2020-03-06 18:33 ` Jarkko Sakkinen
2020-03-06 18:51 ` Stefan Berger
2020-03-07 11:09 ` Jarkko Sakkinen
2020-03-10 21:16 ` Nayna
2020-03-05 11:20 ` [PATCH v6 0/3] Enable vTPM 2.0 for the IBM vTPM driver Jarkko Sakkinen
2020-03-05 13:56 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb90bbef11d054c95e4f4633a350674f3c4fe0c5.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=gcwilson@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).