From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26870C04AAF for ; Mon, 20 May 2019 08:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0475D2081C for ; Mon, 20 May 2019 08:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731064AbfETIRA (ORCPT ); Mon, 20 May 2019 04:17:00 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:32954 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729496AbfETIRA (ORCPT ); Mon, 20 May 2019 04:17:00 -0400 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 7536EA16AA066197D4C3; Mon, 20 May 2019 09:16:58 +0100 (IST) Received: from [10.220.96.108] (10.220.96.108) by smtpsuk.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 09:16:52 +0100 Subject: Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs() To: Arvind Sankar CC: , , , , , , , , , , , , , , , , References: <20190517165519.11507-1-roberto.sassu@huawei.com> <20190517165519.11507-3-roberto.sassu@huawei.com> <20190517210219.GA5998@rani.riverdale.lan> <20190517211014.GA9198@rani.riverdale.lan> From: Roberto Sassu Message-ID: Date: Mon, 20 May 2019 10:16:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190517211014.GA9198@rani.riverdale.lan> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.220.96.108] X-CFilter-Loop: Reflected Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 5/17/2019 11:10 PM, Arvind Sankar wrote: > On Fri, May 17, 2019 at 05:02:20PM -0400, Arvind Sankar wrote: >> On Fri, May 17, 2019 at 01:18:11PM -0700, hpa@zytor.com wrote: >>> >>> Ok... I just realized this does not work for a modular initramfs, composed at load time from multiple files, which is a very real problem. Should be easy enough to deal with: instead of one large file, use one companion file per source file, perhaps something like filename..xattrs (suggesting double dots to make it less likely to conflict with a "real" file.) No leading dot, as it makes it more likely that archivers will sort them before the file proper. >> This version of the patch was changed from the previous one exactly to deal with this case -- >> it allows for the bootloader to load multiple initramfs archives, each >> with its own .xattr-list file, and to have that work properly. >> Could you elaborate on the issue that you see? > Roberto, are you missing a changelog entry for v2->v3 change? The changelog for v1->v2 is missing. Thanks Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI