From: Randy Dunlap <rdunlap@infradead.org>
To: Jaskaran Khurana <jaskarankhurana@linux.microsoft.com>,
gmazyland@gmail.com
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org, agk@redhat.com,
snitzer@redhat.com, dm-devel@redhat.com, jmorris@namei.org,
scottsh@microsoft.com, mdsakib@microsoft.com,
mpatocka@redhat.com, ebiggers@google.com
Subject: Re: [RFC PATCH v7 1/1] Add dm verity root hash pkcs7 sig validation.
Date: Wed, 17 Jul 2019 18:04:46 -0700 [thread overview]
Message-ID: <d057b88f-0a21-0843-1212-af46f67343a2@infradead.org> (raw)
In-Reply-To: <20190718004615.16818-2-jaskarankhurana@linux.microsoft.com>
Hi,
Just a couple of minor nits:
On 7/17/19 5:46 PM, Jaskaran Khurana wrote:
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 3834332f4963..c2b04d226c90 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -490,6 +490,18 @@ config DM_VERITY
>
> If unsure, say N.
>
> +config DM_VERITY_VERIFY_ROOTHASH_SIG
> + def_bool n
It already defaults to n, so we usually try to omit that (don't repeat it).
> + bool "Verity data device root hash signature verification support"
> + depends on DM_VERITY
> + select SYSTEM_DATA_VERIFICATION
> + help
"help" should only be indented by one tab (and not the extra 2 spaces).
> + The device mapper target created by DM-VERITY can be validated if the
> + pre-generated tree of cryptographic checksums passed has a pkcs#7
> + signature file that can validate the roothash of the tree.
> +
> + If unsure, say N.
> +
> config DM_VERITY_FEC
> bool "Verity forward error correction support"
> depends on DM_VERITY
thanks.
--
~Randy
prev parent reply other threads:[~2019-07-18 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 0:46 [RFC PATCH v7 0/1] Add dm verity root hash pkcs7 sig validation Jaskaran Khurana
2019-07-18 0:46 ` [RFC PATCH v7 1/1] " Jaskaran Khurana
2019-07-18 1:04 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d057b88f-0a21-0843-1212-af46f67343a2@infradead.org \
--to=rdunlap@infradead.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=gmazyland@gmail.com \
--cc=jaskarankhurana@linux.microsoft.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mdsakib@microsoft.com \
--cc=mpatocka@redhat.com \
--cc=scottsh@microsoft.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).