archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <>
To: Linus Torvalds <>
Cc: Jarkko Sakkinen <>,
	Linux Kernel Mailing List <>,
	linux-integrity <>,
	James Morris James Morris <>,
	David Howells <>,
	Peter Huewe <>
Subject: Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14
Date: Mon, 28 Jun 2021 15:21:18 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 6/28/21 3:11 PM, Linus Torvalds wrote:
> On Mon, Jun 28, 2021 at 11:33 AM Stefan Berger <> wrote:
>> The removal is triggered by the user changing the type of key from what
>> is in the keyfile.
> So no. No backups either. Because there is not a single valid
> situation where you'd want a backup - because the kernel build should
> never EVER modify the original.
> Maybe I misunderstand what is going on, but I think the whole thing is
> completely wrongly designed. The _only_ key that the kernel build
> should touchn is the auto-generated throw-away one (ie
> "certs/signing_key.pem"), not CONFIG_MODULE_SIG_KEY in general.

Correct, and the code (certs/Makefile) is surrounded by the check for 
this particular file here, so it won't touch anything else:


ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem")

ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)

# Support user changing key type
keytype_openssl = -newkey ec -pkeyopt ec_paramgen_curve:secp384r1
ifeq ($(openssl_available),yes)
$(if $(findstring id-ecPublicKey,$(X509TEXT)),,$(shell rm -f 

ifeq ($(openssl_available),yes)
$(if $(findstring rsaEncryption,$(X509TEXT)),,$(shell rm -f 


There's one dent in this patch series that requires suppressing an error 


>                   Linus

  reply	other threads:[~2021-06-28 19:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 13:56 [GIT PULL] TPM DEVICE DRIVER changes for v5.14 Jarkko Sakkinen
2021-06-28 17:34 ` Linus Torvalds
2021-06-28 18:33   ` Stefan Berger
2021-06-28 19:11     ` Linus Torvalds
2021-06-28 19:21       ` Stefan Berger [this message]
2021-06-28 19:27         ` Linus Torvalds
2021-06-28 19:35           ` Stefan Berger
2021-06-29 20:20   ` Jarkko Sakkinen
2021-06-29 21:08     ` Linus Torvalds
2021-06-29 21:10       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).