From: Stefan Berger <stefanb@linux.ibm.com> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: Jarkko Sakkinen <jarkko@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-integrity <linux-integrity@vger.kernel.org>, James Morris James Morris <jmorris@namei.org>, David Howells <dhowells@redhat.com>, Peter Huewe <peterhuewe@gmx.de> Subject: Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14 Date: Mon, 28 Jun 2021 15:21:18 -0400 [thread overview] Message-ID: <d3fd4b64-be6a-2210-5cfa-fc1947aea293@linux.ibm.com> (raw) In-Reply-To: <CAHk-=wibQ3ahmo0m3BynA3bw2Fkhv0OfMJuV0+wEMwg93Fbj0g@mail.gmail.com> On 6/28/21 3:11 PM, Linus Torvalds wrote: > On Mon, Jun 28, 2021 at 11:33 AM Stefan Berger <stefanb@linux.ibm.com> wrote: >> The removal is triggered by the user changing the type of key from what >> is in the keyfile. > > > So no. No backups either. Because there is not a single valid > situation where you'd want a backup - because the kernel build should > never EVER modify the original. > > Maybe I misunderstand what is going on, but I think the whole thing is > completely wrongly designed. The _only_ key that the kernel build > should touchn is the auto-generated throw-away one (ie > "certs/signing_key.pem"), not CONFIG_MODULE_SIG_KEY in general. Correct, and the code (certs/Makefile) is surrounded by the check for this particular file here, so it won't touch anything else: [...] ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem") ifeq ($(openssl_available),yes) X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text) endif # Support user changing key type ifdef CONFIG_MODULE_SIG_KEY_TYPE_ECDSA keytype_openssl = -newkey ec -pkeyopt ec_paramgen_curve:secp384r1 ifeq ($(openssl_available),yes) $(if $(findstring id-ecPublicKey,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY))) endif endif # CONFIG_MODULE_SIG_KEY_TYPE_ECDSA ifdef CONFIG_MODULE_SIG_KEY_TYPE_RSA ifeq ($(openssl_available),yes) $(if $(findstring rsaEncryption,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY))) endif endif # CONFIG_MODULE_SIG_KEY_TYPE_RSA [...] There's one dent in this patch series that requires suppressing an error output: https://lkml.org/lkml/2021/6/25/452 Stefan > > Linus
next prev parent reply other threads:[~2021-06-28 19:21 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-23 13:56 Jarkko Sakkinen 2021-06-28 17:34 ` Linus Torvalds 2021-06-28 18:33 ` Stefan Berger 2021-06-28 19:11 ` Linus Torvalds 2021-06-28 19:21 ` Stefan Berger [this message] 2021-06-28 19:27 ` Linus Torvalds 2021-06-28 19:35 ` Stefan Berger 2021-06-29 20:20 ` Jarkko Sakkinen 2021-06-29 21:08 ` Linus Torvalds 2021-06-29 21:10 ` Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3fd4b64-be6a-2210-5cfa-fc1947aea293@linux.ibm.com \ --to=stefanb@linux.ibm.com \ --cc=dhowells@redhat.com \ --cc=jarkko@kernel.org \ --cc=jmorris@namei.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=torvalds@linux-foundation.org \ --subject='Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).