From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Petr Vorel <pvorel@suse.cz>, Mimi Zohar <zohar@linux.ibm.com>
Cc: Vitaly Chikunov <vt@altlinux.org>,
Stefan Berger <stefanb@linux.ibm.com>,
linux-integrity@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>,
"YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH ima-evm-utils v2] ima-evm-utils: Fix incorrect algorithm name in hash_info.gen
Date: Fri, 23 Jul 2021 21:07:21 +0800 [thread overview]
Message-ID: <d6ba47d1-595d-3deb-765e-71e31c332d0a@linux.alibaba.com> (raw)
In-Reply-To: <YPqvqoyM0lpiH4R5@pevik>
Hi Mimi, Petr,
On 7/23/21 8:01 PM, Petr Vorel wrote:
> Hi Tianjia, Mimi,
>
>> Hi Tianjia,
>
>> On Fri, 2021-07-23 at 14:41 +0800, Tianjia Zhang wrote:
>>> There is no such an algorithm name as sm3-256. This is an ambiguity
>>> caused by the definition of the macro HASH_ALGO_SM3_256. The sed
>>> command is only a special case of sm3, so sm3 is used to replace
>>> the sm3-256 algorithm name.
>
>>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>> ---
>>> src/.gitignore | 1 +
>>> src/hash_info.gen | 7 ++++---
>>> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>>> diff --git a/src/.gitignore b/src/.gitignore
>>> index 38e8e3c..69d2988 100644
>>> --- a/src/.gitignore
>>> +++ b/src/.gitignore
>>> @@ -1 +1,2 @@
>>> hash_info.h
>>> +tmp_hash_info.h
>>> diff --git a/src/hash_info.gen b/src/hash_info.gen
>>> index 5f7a97f..f52bb4d 100755
>>> --- a/src/hash_info.gen
>>> +++ b/src/hash_info.gen
>>> @@ -84,9 +84,10 @@ echo "};"
>>> echo "const char *const hash_algo_name[HASH_ALGO__LAST] = {"
>>> sed -n 's/HASH_ALGO_\(.*\),/\1 \L\1\E/p' $HASH_INFO | \
>>> while read a b; do
>>> - # Normalize text hash name: if it contains underscore between
>>> - # digits replace it with a dash, other underscores are removed.
>>> - b=$(echo "$b" | sed "s/\([0-9]\)_\([0-9]\)/\1-\2/g;s/_//g")
>>> + # Normalize text hash name: sm3 algorithm name is different from
>>> + # the macro definition, which is also the only special case, and
>>> + # underscores are removed.
>
>> Thank you for updating the comment. Do you mind if I tweak it a bit:
>
>> ^which is also the only special case of an underscore between digits.
>> Remove all other underscores.
> +1
>
I'm glad you can tweak it, I'm sorry I didn't express it clarity.
Cheers,
Tianjia
> Kind regards,
> Petr
>
>> Mimi
>
>>> + b=$(echo "$b" | sed "s/sm3_256/sm3/g;s/_//g")
>>> printf '\t%-26s = "%s",\n' "[HASH_ALGO_$a]" "$b"
>>> done
>>> echo "};"
>
prev parent reply other threads:[~2021-07-23 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 6:41 [PATCH ima-evm-utils v2] ima-evm-utils: Fix incorrect algorithm name in hash_info.gen Tianjia Zhang
2021-07-23 11:55 ` Mimi Zohar
2021-07-23 12:01 ` Petr Vorel
2021-07-23 13:07 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6ba47d1-595d-3deb-765e-71e31c332d0a@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=YiLin.Li@linux.alibaba.com \
--cc=linux-integrity@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=stefanb@linux.ibm.com \
--cc=vt@altlinux.org \
--cc=zhang.jia@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).