From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90218C4332E for ; Sun, 22 Mar 2020 00:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60FA620776 for ; Sun, 22 Mar 2020 00:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728120AbgCVAcT (ORCPT ); Sat, 21 Mar 2020 20:32:19 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:58026 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbgCVAcT (ORCPT ); Sat, 21 Mar 2020 20:32:19 -0400 Received: from fsav303.sakura.ne.jp (fsav303.sakura.ne.jp [153.120.85.134]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 02M0VQKJ025665; Sun, 22 Mar 2020 09:31:26 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav303.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav303.sakura.ne.jp); Sun, 22 Mar 2020 09:31:26 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav303.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 02M0VLN8025536 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Mar 2020 09:31:26 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Subject: Re: [PATCH v7 2/2] KEYS: Avoid false positive ENOMEM error on key read To: Waiman Long Cc: David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , "David S. Miller" , Jakub Kicinski , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen References: <20200321184932.16579-1-longman@redhat.com> <20200321184932.16579-3-longman@redhat.com> From: Tetsuo Handa Message-ID: Date: Sun, 22 Mar 2020 09:31:21 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200321184932.16579-3-longman@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 2020/03/22 3:49, Waiman Long wrote: > + do { > + if (ret > key_data_len) { > + if (unlikely(key_data)) > + __kvzfree(key_data, key_data_len); > + key_data_len = ret; > + continue; /* Allocate buffer */ Excuse me, but "continue;" inside "do { ... } while (0);" means "break;" because "while (0)" is evaluated before continuing the loop. ---------- #include int main(int argc, char *argv[]) { do { printf("step 1\n"); if (1) { printf("step 2\n"); continue; } printf("step 3\n"); } while (0); printf("step 4\n"); return 0; } ---------- ---------- step 1 step 2 step 4 ---------- > + } > + } while (0);