linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Peter.Huewe@infineon.com>
To: <jarkko.sakkinen@linux.intel.com>, <linux-integrity@vger.kernel.org>
Cc: <kjhall@us.ibm.com>, <ferry.toth@elsinga.info>,
	<peterhuewe@gmx.de>, <jgg@ziepe.ca>, <arnd@arndb.de>,
	<gregkh@linuxfoundation.org>, <akpm@osdl.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] tpm_tis: Remove the HID IFX0102
Date: Mon, 6 Jul 2020 11:46:46 +0000	[thread overview]
Message-ID: <e9caad58aba44bb3abeac8569a6bd8ed@infineon.com> (raw)
In-Reply-To: <20200625023111.270458-1-jarkko.sakkinen@linux.intel.com>

Hi,
NACK

> % git --no-pager grep IFX0102 drivers/char/tpm
> drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
> Obviously IFX0102 was added to the HID table for the TCG TIS driver by mistake.

The HID IFX0102 was NOT added by mistake.
Let me explain the history a bit:

Old SLB 9635 / 9630 TPMs had two ways to interface them
- proprietary 'io' mapped protocol (tpm_infineon)
- tis protocol  (tpm_tis)

Both match the same HID.
However with the emerging of the tis protocol, the io protocol eventually went away for newer products.
So all TPM1.2 by IFX match the HID0102 and the TCG generic ones PNP0C31

So basically you break TPM1.2 support for all (newer) Infineon chips if the platform vendor used the IFX0102 HID as they would speak via tpm_infineon driver.
The bug must be something different, especially as it only seems to happen after suspend resume.


Thanks,
Peter

  parent reply	other threads:[~2020-07-06 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  2:31 [PATCH v2] tpm_tis: Remove the HID IFX0102 Jarkko Sakkinen
2020-06-25  6:21 ` Jerry Snitselaar
2020-06-25 21:02   ` Jarkko Sakkinen
2020-06-25 21:19     ` Jerry Snitselaar
2020-06-25 21:23       ` James Bottomley
2020-06-26 13:15         ` Jarkko Sakkinen
2020-06-26 14:36           ` James Bottomley
2020-07-02 23:37             ` Jarkko Sakkinen
2020-06-26 13:08       ` Jarkko Sakkinen
2020-06-30 19:15         ` Jerry Snitselaar
2020-07-02 23:38           ` Jarkko Sakkinen
2020-07-06 11:46 ` Peter.Huewe [this message]
2020-07-06 14:00   ` Jarkko Sakkinen
2020-07-06 14:43     ` Jarkko Sakkinen
2020-07-06 14:47       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9caad58aba44bb3abeac8569a6bd8ed@infineon.com \
    --to=peter.huewe@infineon.com \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=ferry.toth@elsinga.info \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=kjhall@us.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).