From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AD6C433E0 for ; Fri, 15 Jan 2021 17:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38CB123382 for ; Fri, 15 Jan 2021 17:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbhAOR1L (ORCPT ); Fri, 15 Jan 2021 12:27:11 -0500 Received: from bedivere.hansenpartnership.com ([96.44.175.130]:51130 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbhAOR1L (ORCPT ); Fri, 15 Jan 2021 12:27:11 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id BD3901280891; Fri, 15 Jan 2021 09:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1610731590; bh=rYHSOlgfwH4DYPp5D6X9165y63QWKKlITcx8p95s98A=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=m3xE1ewBl35LGetY2/FWMPqCUoyOS3dvppAtsjHBL+naZhxJ9CRxn3ABaLmpHimsN +3QQXrhtvheeNT7KFhsPPZxUZlyimRdNS9hWlIj+Tw1FvU4dkXru2qHJvpIpPMKnPq J124BzSgVEmauZBarKXxVgIpgJN4WfPmyo+Mnc6U= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eDK5fCppuG0u; Fri, 15 Jan 2021 09:26:30 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (unknown [IPv6:2601:600:8280:66d1::c447]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 551C7128088F; Fri, 15 Jan 2021 09:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1610731590; bh=rYHSOlgfwH4DYPp5D6X9165y63QWKKlITcx8p95s98A=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=m3xE1ewBl35LGetY2/FWMPqCUoyOS3dvppAtsjHBL+naZhxJ9CRxn3ABaLmpHimsN +3QQXrhtvheeNT7KFhsPPZxUZlyimRdNS9hWlIj+Tw1FvU4dkXru2qHJvpIpPMKnPq J124BzSgVEmauZBarKXxVgIpgJN4WfPmyo+Mnc6U= Message-ID: Subject: Re: [PATCH v5 1/2] tpm: add sysfs exports for all banks of PCR registers From: James Bottomley To: Greg KH , Joe Perches Cc: linux-integrity@vger.kernel.org, Mimi Zohar , Jarkko Sakkinen , linux-api@vger.kernel.org Date: Fri, 15 Jan 2021 09:26:29 -0800 In-Reply-To: References: <20210113232634.23242-1-James.Bottomley@HansenPartnership.com> <20210113232634.23242-2-James.Bottomley@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, 2021-01-15 at 14:54 +0100, Greg KH wrote: > On Thu, Jan 14, 2021 at 04:21:08PM -0800, James Bottomley wrote: [...] > > It looks like we already have a couple of bugs in the kernel > > introduced by this confusion ... return sysfs_emit() vs return > > sysfs_emit_at() being the most tricky ... > > Hm, Joe, you did the conversion to these functions (and wrote the > api), care to review this? A cursory glance tells me that summary_show in drivers/infiniband/hw/usnic/usnic_ib_sysfs.c has a problem, I think the last = should be += James