From: Stefan Berger <stefanb@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-integrity <linux-integrity@vger.kernel.org>,
James Morris James Morris <jmorris@namei.org>,
David Howells <dhowells@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14
Date: Mon, 28 Jun 2021 15:35:16 -0400 [thread overview]
Message-ID: <efeb27d1-5c75-b61f-0cc4-583a589e0f7f@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wgQJESJ-q-4FNgwpTJTZrEr033gzpXM2gWWviVOHJNnaQ@mail.gmail.com>
On 6/28/21 3:27 PM, Linus Torvalds wrote:
> On Mon, Jun 28, 2021 at 12:21 PM Stefan Berger <stefanb@linux.ibm.com> wrote:
>> Correct, and the code (certs/Makefile) is surrounded by the check for
>> this particular file here, so it won't touch anything else:
> Ahh, I missed that part.
>
> Can we just make it really really obvious, and not use
> CONFIG_MODULE_SIG_KEY at all, then?
>
> IOW, make these literally be about "certs/signing_key.pem" and nothing
> else, so that when people grep for this, or look at the Makefile, they
> don't fall into that trap I fell into?
Yes, sir.
Stefan
>
> That also would make it obvious that there are no pathname quoting issues etc.
>
> Linus
next prev parent reply other threads:[~2021-06-28 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 13:56 Jarkko Sakkinen
2021-06-28 17:34 ` Linus Torvalds
2021-06-28 18:33 ` Stefan Berger
2021-06-28 19:11 ` Linus Torvalds
2021-06-28 19:21 ` Stefan Berger
2021-06-28 19:27 ` Linus Torvalds
2021-06-28 19:35 ` Stefan Berger [this message]
2021-06-29 20:20 ` Jarkko Sakkinen
2021-06-29 21:08 ` Linus Torvalds
2021-06-29 21:10 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efeb27d1-5c75-b61f-0cc4-583a589e0f7f@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=torvalds@linux-foundation.org \
--subject='Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).