linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: nramas <nramas@linux.microsoft.com>, linux-integrity@vger.kernel.org
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
	Stefan Berger <stefanb@linux.ibm.com>,
	Russell Coker <russell@coker.com.au>
Subject: Re: [RFC PATCH 2/2] evm: output EVM digest calculation info needed for debugging
Date: Thu, 03 Jun 2021 12:55:14 -0400	[thread overview]
Message-ID: <f29c8302fbb83fa05cf4cddb48144e32b14a6851.camel@linux.ibm.com> (raw)
In-Reply-To: <a994cedd0b2a07faf8d1949448ec9c14b3dba34c.camel@linux.microsoft.com>

Hi Lakshmi,

On Thu, 2021-06-03 at 09:34 -0700, nramas wrote:
> > +void evm_bin2hex_print(const char *prefix, const void *src, size_t
> > count);
> >  
> 
> For evm_bin2hex_print() can we could do the following in evm.h?
> 
> #ifdef DEBUG
> void evm_bin2hex_print(const char *prefix, const void *src, size_t
> count);
> #else
> void evm_bin2hex_print(const char *prefix, const void *src, size_t
> count) {}
> #endif /* DEBUG */

Yes, if we decide that it needs to be based on DEBUG, this would be the
proper way of doing it.  However, since there's nothing really private
here, it's just displaying the security xattrs and other file metadata,
should enabling/disabling the debugging be runtime configurable?   Kind
of like how print_hex_dump() relies on loglevel.  Or should it be more
granular?

thanks,

Mimi


  reply	other threads:[~2021-06-03 16:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 15:18 [RFC PATCH 0/2] EVM: add some debugging info Mimi Zohar
2021-06-03 15:18 ` [RFC PATCH 1/2] ima: differentiate between EVM failures in the audit log Mimi Zohar
2021-06-04  6:37   ` Roberto Sassu
2021-06-03 15:18 ` [RFC PATCH 2/2] evm: output EVM digest calculation info needed for debugging Mimi Zohar
2021-06-03 16:34   ` nramas
2021-06-03 16:55     ` Mimi Zohar [this message]
2021-06-03 17:48       ` nramas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f29c8302fbb83fa05cf4cddb48144e32b14a6851.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=roberto.sassu@huawei.com \
    --cc=russell@coker.com.au \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).