From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA165C433E6 for ; Thu, 14 Jan 2021 16:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C333B23B1C for ; Thu, 14 Jan 2021 16:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726438AbhANQvc (ORCPT ); Thu, 14 Jan 2021 11:51:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:3170 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726224AbhANQvc (ORCPT ); Thu, 14 Jan 2021 11:51:32 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10EGgtVY056001; Thu, 14 Jan 2021 11:50:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=lPHzalP1xIyx5PPxmOxaK+N/SJ9f/dq5jXZ5Jr3aig4=; b=nm51b0XrXSG8IezJ/mDS4n5VmfM6F4xXJrc8v/qYngKHezmSN+b5X09hFPPJ0OpART20 AExF31vYBDf3skgYFHMCN1A3wTO31zYTKsgXwNKnV+4TkJKKpDZ4GHUItk8GJyDXVyBL DLNdS8OEoyY0K5KoYPgUsm2goi34t8JWbbsFPlnhM58taSNGxiP6XFbwmTw3oPzgoSaP owvx2mcrNx9lM9xfW4XegXp4iwo9kw9BjuoIfhKsHyFcPjFuSCpSNkaHx9MqE//3j8tE fUMju8SM7B8vaODUeJ18p/sS5uhUVcbgEHTVh7dByjwnUjYQ3UDiupcLXM6Xwvxyz5K9 CQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 362sqbr6sa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jan 2021 11:50:46 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 10EGhhl7061041; Thu, 14 Jan 2021 11:50:44 -0500 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 362sqbr6r0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jan 2021 11:50:44 -0500 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10EGlIH3009853; Thu, 14 Jan 2021 16:50:41 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03ams.nl.ibm.com with ESMTP id 35y447xn1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jan 2021 16:50:41 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10EGodWb46858724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Jan 2021 16:50:39 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A3354C058; Thu, 14 Jan 2021 16:50:39 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D80814C04E; Thu, 14 Jan 2021 16:50:35 +0000 (GMT) Received: from sig-9-65-209-51.ibm.com (unknown [9.65.209.51]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 14 Jan 2021 16:50:35 +0000 (GMT) Message-ID: Subject: Re: [PATCH v10 8/8] selinux: include a consumer of the new IMA critical data hook From: Mimi Zohar To: Lakshmi Ramasubramanian , Paul Moore , Sasha Levin Cc: Tushar Sugandhi , Stephen Smalley , casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, tyhicks@linux.microsoft.com, James Morris , linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com Date: Thu, 14 Jan 2021 11:50:34 -0500 In-Reply-To: <99be76345f375bb2f485f08a53dcb8ed806dc538.camel@linux.ibm.com> References: <20210108040708.8389-1-tusharsu@linux.microsoft.com> <20210108040708.8389-9-tusharsu@linux.microsoft.com> <97328fc71687a0e1c327f6821548be9ba35bb193.camel@linux.ibm.com> <71cddb6c8676ccd63c89364d805cfca76d32cb6e.camel@linux.ibm.com> <3746bc7673df25354411151442a7772b867be396.camel@linux.ibm.com> <99be76345f375bb2f485f08a53dcb8ed806dc538.camel@linux.ibm.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-14.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-14_05:2021-01-14,2021-01-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101140091 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2021-01-14 at 11:44 -0500, Mimi Zohar wrote: > [Cc'ing Sasha] > > Hi Lakshmi, > > On Thu, 2021-01-14 at 08:22 -0800, Lakshmi Ramasubramanian wrote: > > On 1/13/21 6:49 PM, Mimi Zohar wrote: > > > >>> Lakshmi is trying to address the situation where an event changes a > > >>> value, but then is restored to the original value. The original and > > >>> subsequent events are measured, but restoring to the original value > > >>> isn't re-measured. This isn't any different than when a file is > > >>> modified and then reverted. > > >>> > > >>> Instead of changing the name like this, which doesn't work for files, > > >>> allowing duplicate measurements should be generic, based on policy. > > >> > > >> Perhaps it is just the end of the day and I'm a bit tired, but I just > > >> read all of the above and I have no idea what your current thoughts > > >> are regarding this patch. > > > > > > Other than appending the timestamp, which is a hack, the patch is fine. > > > Support for re-measuring an event can be upstreamed independently. > > > > > > > Thanks for clarifying the details related to duplicate measurement > > detection and re-measuring. > > > > I will keep the timestamp for the time being, even though its a hack, as > > it helps with re-measuring state changes in SELinux. We will add support > > for "policy driven" re-measurement as a subsequent patch series. > > Once including the timestamp is upstreamed, removing it will be > difficult, especially if different userspace applications are dependent > on it. Unless everyone is on board that removing the timestamp > wouldn't be considered a regression, it cannot be upstreamed. Feel free to just re-post just this one patch. Otherwise the patch set looks good. thanks, Mimi