From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B219AC433FF for ; Fri, 9 Aug 2019 20:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90182214C6 for ; Fri, 9 Aug 2019 20:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727275AbfHIU2T (ORCPT ); Fri, 9 Aug 2019 16:28:19 -0400 Received: from mga11.intel.com ([192.55.52.93]:13225 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbfHIU2S (ORCPT ); Fri, 9 Aug 2019 16:28:18 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 13:28:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,366,1559545200"; d="scan'208";a="166108401" Received: from wulili-mobl1.ger.corp.intel.com ([10.249.36.9]) by orsmga007.jf.intel.com with ESMTP; 09 Aug 2019 13:28:14 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] tpm: tpm_tis_spi: Export functionality to other drivers From: Jarkko Sakkinen To: Stephen Boyd , Peter Huewe Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Andrey Pronin , Duncan Laurie , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Alexander Steffen Date: Fri, 09 Aug 2019 23:28:13 +0300 In-Reply-To: <20190806220750.86597-3-swboyd@chromium.org> References: <20190806220750.86597-1-swboyd@chromium.org> <20190806220750.86597-3-swboyd@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, 2019-08-06 at 15:07 -0700, Stephen Boyd wrote: > We want to use most of the code in this driver, except we want to modify > the flow control and idle behavior. Let's "libify" this driver so that > another driver can call the code in here and slightly tweak the > behavior. Neither "libifying" nor "slightly tweaking" gives an idea what the commit does. A great commit message should be in imperative form describe what it does and why in as plain english as possible. Often commit messages are seen just as a necessary bad and not much energy is spent on them but for a maitainer solid commit messages have an indispensable value. > + void (*pre_transfer)(struct tpm_tis_spi_phy *phy); Adding a new calback should be a commit of its own. /Jarkko