linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer'
@ 2021-06-10 17:15 Lakshmi Ramasubramanian
  2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Lakshmi Ramasubramanian @ 2021-06-10 17:15 UTC (permalink / raw)
  To: zohar, robh, bauerman
  Cc: kbuild-all, clang-built-linux, linux-integrity, linux-kernel, tusharsu

The function prototype for ima_add_kexec_buffer() is present
in 'linux/ima.h'.  But this header file is not included in
ima_kexec.c where the function is implemented.  This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:

  security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
  for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]

Include the header file 'linux/ima.h' in ima_kexec.c to fix
the compiler warning.

Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
---
 security/integrity/ima/ima_kexec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
index 667887665823..f799cc278a9a 100644
--- a/security/integrity/ima/ima_kexec.c
+++ b/security/integrity/ima/ima_kexec.c
@@ -11,6 +11,7 @@
 #include <linux/vmalloc.h>
 #include <linux/kexec.h>
 #include <linux/of.h>
+#include <linux/ima.h>
 #include "ima.h"
 
 #ifdef CONFIG_IMA_KEXEC
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
  2021-06-10 17:15 [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Lakshmi Ramasubramanian
@ 2021-06-10 17:15 ` Lakshmi Ramasubramanian
  2021-06-10 17:36   ` Rob Herring
  2021-06-11  1:24   ` Mimi Zohar
  2021-06-10 17:34 ` [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Rob Herring
  2021-06-11 15:41 ` Mimi Zohar
  2 siblings, 2 replies; 6+ messages in thread
From: Lakshmi Ramasubramanian @ 2021-06-10 17:15 UTC (permalink / raw)
  To: zohar, robh, bauerman
  Cc: kbuild-all, clang-built-linux, linux-integrity, linux-kernel, tusharsu

The function prototype for ima_post_key_create_or_update() is present
in 'linux/ima.h'.  But this header file is not included in
ima_asymmetric_keys.c where the function is implemented.  This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:

  security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
  prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]

Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
fix the compiler warning.

Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
Cc: stable@vger.kernel.org
Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
---
 security/integrity/ima/ima_asymmetric_keys.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/ima/ima_asymmetric_keys.c b/security/integrity/ima/ima_asymmetric_keys.c
index 1fb0b0e09559..c985418698a4 100644
--- a/security/integrity/ima/ima_asymmetric_keys.c
+++ b/security/integrity/ima/ima_asymmetric_keys.c
@@ -11,6 +11,7 @@
 
 #include <keys/asymmetric-type.h>
 #include <linux/user_namespace.h>
+#include <linux/ima.h>
 #include "ima.h"
 
 /**
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer'
  2021-06-10 17:15 [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Lakshmi Ramasubramanian
  2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
@ 2021-06-10 17:34 ` Rob Herring
  2021-06-11 15:41 ` Mimi Zohar
  2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-06-10 17:34 UTC (permalink / raw)
  To: Lakshmi Ramasubramanian
  Cc: Mimi Zohar, Thiago Jung Bauermann, kbuild-all, clang-built-linux,
	linux-integrity, linux-kernel, tusharsu

On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas@linux.microsoft.com> wrote:
>
> The function prototype for ima_add_kexec_buffer() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_kexec.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
>
>   security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
>   for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
>
> Include the header file 'linux/ima.h' in ima_kexec.c to fix
> the compiler warning.
>
> Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> ---
>  security/integrity/ima/ima_kexec.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
  2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
@ 2021-06-10 17:36   ` Rob Herring
  2021-06-11  1:24   ` Mimi Zohar
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-06-10 17:36 UTC (permalink / raw)
  To: Lakshmi Ramasubramanian
  Cc: Mimi Zohar, Thiago Jung Bauermann, kbuild-all, clang-built-linux,
	linux-integrity, linux-kernel, tusharsu

On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas@linux.microsoft.com> wrote:
>
> The function prototype for ima_post_key_create_or_update() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_asymmetric_keys.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
>
>   security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
>   prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
>
> Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
> fix the compiler warning.
>
> Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
> Cc: stable@vger.kernel.org
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> ---
>  security/integrity/ima/ima_asymmetric_keys.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
  2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
  2021-06-10 17:36   ` Rob Herring
@ 2021-06-11  1:24   ` Mimi Zohar
  1 sibling, 0 replies; 6+ messages in thread
From: Mimi Zohar @ 2021-06-11  1:24 UTC (permalink / raw)
  To: Lakshmi Ramasubramanian, robh
  Cc: kbuild-all, clang-built-linux, linux-integrity, linux-kernel, tusharsu

Hi Lakshmi,

On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
> The function prototype for ima_post_key_create_or_update() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_asymmetric_keys.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
> 
>   security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
>   prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
> 
> Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
> fix the compiler warning.
> 
> Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
> Cc: stable@vger.kernel.org
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>

Roberto posted an equivalent patch "[PATCH 4/5] ima: Include header
defining ima_post_key_create_or_update()" earlier this week.

Compiler warnings don't meet the requirements for stable -
Documentation/process/stable-kernel-rules.rst.

thanks,

Mimi


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer'
  2021-06-10 17:15 [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Lakshmi Ramasubramanian
  2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
  2021-06-10 17:34 ` [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Rob Herring
@ 2021-06-11 15:41 ` Mimi Zohar
  2 siblings, 0 replies; 6+ messages in thread
From: Mimi Zohar @ 2021-06-11 15:41 UTC (permalink / raw)
  To: Lakshmi Ramasubramanian, robh, bauerman
  Cc: kbuild-all, clang-built-linux, linux-integrity, linux-kernel, tusharsu

On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
> The function prototype for ima_add_kexec_buffer() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_kexec.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
> 
>   security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
>   for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
> 
> Include the header file 'linux/ima.h' in ima_kexec.c to fix
> the compiler warning.
> 
> Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>

Thanks!

Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-
integrity.git next-integrity-testing and next-integrity branches.

Mimi


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-11 15:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 17:15 [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Lakshmi Ramasubramanian
2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
2021-06-10 17:36   ` Rob Herring
2021-06-11  1:24   ` Mimi Zohar
2021-06-10 17:34 ` [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Rob Herring
2021-06-11 15:41 ` Mimi Zohar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).