Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Nayna <nayna@linux.vnet.ibm.com>,
	linux-integrity@vger.kernel.org, zohar@linux.ibm.com,
	sashal@kernel.org, jamorris@linux.microsoft.com,
	kgoldman@us.ibm.com, mjg59@google.com, dhowells@redhat.com
Cc: balajib@linux.microsoft.com, prsriva@linux.microsoft.com,
	jorhand@linux.microsoft.com, patatash@linux.microsoft.com
Subject: Re: [PATCH v0 1/2] KEYS: Measure keys added to builtin or secondary trusted keys keyring
Date: Mon, 14 Oct 2019 09:21:33 -0700
Message-ID: <f8e1e16f-ac60-7c95-f4fd-82a9926dc61c@linux.microsoft.com> (raw)
In-Reply-To: <9f015e69-ba6c-8631-d3b4-e60501dd97d8@linux.vnet.ibm.com>

On 10/13/19 11:34 AM, Nayna wrote:

> Hi Lakshmi,
> I am wondering that even though there is just one argument change in the 
> process_buffer_measurement() function, a full new function is defined. 
> This makes reviewing the function more difficult than it should be. Can 
> you please check on how the patch is getting formatted ?
> 
> Moreover, I am already modifying this function as part of the blacklist 
> patchset, but in a different way. Please refer to the Patch [5/8] in the 
> patchset titled "powerpc: Enabling IMA arch specific secure boot 
> policies". It was posted on 8th October.
> 
> I will modify the process_buffer_measurement() function in a way that 
> can work for both of our requirements and will post a new version soon.
> 
> Thanks & Regards,
>       - Nayna

Hi Nayna,

I think it is because I moved the function towards the top of the file - 
so it appears like a delete and an add instead of a minor change :(

Please let me know when you send your change. I'll take a look.

thanks,
  -lakshmi




  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 17:35 [PATCH v0 0/2] " Lakshmi Ramasubramanian
2019-10-11 17:35 ` [PATCH v0 1/2] " Lakshmi Ramasubramanian
2019-10-13  2:49   ` Mimi Zohar
2019-10-13 18:34   ` Nayna
2019-10-14 16:21     ` Lakshmi Ramasubramanian [this message]
2019-10-11 17:35 ` [PATCH v0 2/2] KEYS: LSM Hook for key_create_or_update Lakshmi Ramasubramanian
2019-10-13  2:57   ` Mimi Zohar

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8e1e16f-ac60-7c95-f4fd-82a9926dc61c@linux.microsoft.com \
    --to=nramas@linux.microsoft.com \
    --cc=balajib@linux.microsoft.com \
    --cc=dhowells@redhat.com \
    --cc=jamorris@linux.microsoft.com \
    --cc=jorhand@linux.microsoft.com \
    --cc=kgoldman@us.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=patatash@linux.microsoft.com \
    --cc=prsriva@linux.microsoft.com \
    --cc=sashal@kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git