From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Peter Huewe" <peterhuewe@gmx.de>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/3] tpm: Convert to platform remove callback returning void
Date: Sun, 23 Apr 2023 09:13:57 +0300 [thread overview]
Message-ID: <f8e9ef81082ecdde4e73e27e33ad8648bb70ab9a.camel@kernel.org> (raw)
In-Reply-To: <20230417060533.guw7kqfbf4t3dytr@pengutronix.de>
On Mon, 2023-04-17 at 08:05 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Mar 20, 2023 at 09:06:04AM +0100, Uwe Kleine-König wrote:
> > this series adapts the platform drivers below drivers/char/tpm to use the
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> >
> > The drivers converted here returned zero in their remove callback, to the
> > transformation was easy.
>
> who is responsible to pick up this patch set (or express their concerns
> when not applying it)?
>
> There is (for now) no coordination necessary, the final conversion of
> platform_driver's remove callback is still far away. So applying it via
> it's usual repo would be great.
Please check https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/
If you see anything abnormal, please report, and I will fix before sending
the pull request to Linus.
BR, Jarkko
next prev parent reply other threads:[~2023-04-23 6:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:06 [PATCH 0/3] tpm: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-20 8:06 ` [PATCH 1/3] tpm/tpm_ftpm_tee: " Uwe Kleine-König
2023-03-20 8:06 ` [PATCH 2/3] tpm/tpm_tis: " Uwe Kleine-König
2023-03-20 8:06 ` [PATCH 3/3] tpm/tpm_tis_synquacer: " Uwe Kleine-König
2023-03-20 13:48 ` [PATCH 0/3] tpm: " Jarkko Sakkinen
2023-04-17 6:05 ` Uwe Kleine-König
2023-04-23 6:13 ` Jarkko Sakkinen [this message]
2023-04-23 8:02 ` Uwe Kleine-König
2023-04-23 15:44 ` Jarkko Sakkinen
2023-04-23 5:08 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e9ef81082ecdde4e73e27e33ad8648bb70ab9a.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel@pengutronix.de \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).