From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C717AC432BE for ; Tue, 27 Jul 2021 04:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A79CA6108E for ; Tue, 27 Jul 2021 04:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234841AbhG0EZC (ORCPT ); Tue, 27 Jul 2021 00:25:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbhG0EZA (ORCPT ); Tue, 27 Jul 2021 00:25:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB45C061760 for ; Mon, 26 Jul 2021 21:25:01 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m8EeJ-00047E-E9; Tue, 27 Jul 2021 06:24:59 +0200 Subject: Re: [PATCH v2] KEYS: trusted: fix use as module when CONFIG_TCG_TPM=m To: Jarkko Sakkinen Cc: James Morris , "Serge E. Hallyn" , James Bottomley , Mimi Zohar , Sumit Garg , David Howells , Herbert Xu , "David S. Miller" , kernel@pengutronix.de, Andreas Rammhold , David Gstir , Richard Weinberger , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org References: <20210721160258.7024-1-a.fatoum@pengutronix.de> <20210727030433.3dwod2elwtdkhwsc@kernel.org> From: Ahmad Fatoum Message-ID: Date: Tue, 27 Jul 2021 06:24:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210727030433.3dwod2elwtdkhwsc@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-integrity@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 27.07.21 05:04, Jarkko Sakkinen wrote: >> Reported-by: Andreas Rammhold >> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") >> Signed-off-by: Ahmad Fatoum > > Is it absolutely need to do all this *just* to fix the bug? > > For a pure bug fix the most essential thing is to be able the backport > it to stable kernels. Not much happened in-between, so a backport should be trivial. I can provide these if needed. > I don't really care at all about extra niceties ("it's now possible > stuff). > > This looks like a bug fix and improvements bundle into a single patch. You can replace the #ifdefs with #if IS_REACHABLE in trusted_core.c to fix the intermediate breakage and then throw that away again to fix the remaining dependency of trusted keys on TCG_TPM. If you prefer that, Andreas perhaps could respin his series with s/IS_ENABLED/IS_REACHABLE/? Cheers, Ahmad > > /Jarkko > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |