From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9D0C17441 for ; Mon, 11 Nov 2019 14:43:38 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3906321655 for ; Mon, 11 Nov 2019 14:43:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3906321655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1D80DCA6; Mon, 11 Nov 2019 14:43:38 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id F2393AD0 for ; Mon, 11 Nov 2019 14:43:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 996F012E for ; Mon, 11 Nov 2019 14:43:35 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 052C131B; Mon, 11 Nov 2019 06:43:35 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AC603F52E; Mon, 11 Nov 2019 06:43:33 -0800 (PST) Subject: Re: [PATCH 2/2] iommu/arm-smmu: Remove duplicate error message To: Jean-Philippe Brucker , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org References: <20191111111721.4145919-1-jean-philippe@linaro.org> <20191111111721.4145919-2-jean-philippe@linaro.org> From: Robin Murphy Message-ID: <09ac62ed-c483-79ba-bd31-939b50e8d20f@arm.com> Date: Mon, 11 Nov 2019 14:43:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191111111721.4145919-2-jean-philippe@linaro.org> Content-Language: en-GB Cc: will@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On 11/11/2019 11:17, Jean-Philippe Brucker wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()"), platform_get_irq() displays an error when the > IRQ isn't found. Remove the error print from the SMMU driver. Note the > slight change of behaviour: no message is printed if platform_get_irq() > returns -EPROBE_DEFER, which probably doesn't concern the SMMU. > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 7c503a6bc585..6f676686752c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2062,10 +2062,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > for (i = 0; i < num_irqs; ++i) { > int irq = platform_get_irq(pdev, i); > > - if (irq < 0) { > - dev_err(dev, "failed to get irq index %d\n", i); > + if (irq < 0) > return -ENODEV; It's a preexisting issue, but we should really "return irq" here. Robin. > - } > smmu->irqs[i] = irq; > } > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu